2017-03-16 07:00:09

by Miguel Bernal Marin

Subject: [PATCH] scsi: storvsc: remove return at end of void function

storvsc_on_channel_callback is a void function and the return
statement at the end is not useful.

Found with checkpatch.

Signed-off-by: Miguel Bernal Marin <[email protected]>
---
drivers/scsi/storvsc_drv.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index 3d70d1cf49a3..538f3e131275 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -1191,8 +1191,6 @@ static void storvsc_on_channel_callback(void *context)
break;
}
} while (1);
-
- return;
}

static int storvsc_connect_to_vsp(struct hv_device *device, u32 ring_size,
--
2.12.0

2017-04-13 23:29:00

by KY Srinivasan

Subject: RE: [PATCH] scsi: storvsc: remove return at end of void function

> -----Original Message-----
> From: Miguel Bernal Marin [mailto:[email protected]]
> Sent: Thursday, March 16, 2017 12:00 AM
> To: KY Srinivasan <[email protected]>; Martin K. Petersen
> <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; Haiyang Zhang <[email protected]>;
> Stephen Hemminger <[email protected]>; James E.J. Bottomley
> <[email protected]>
> Subject: [PATCH] scsi: storvsc: remove return at end of void function
>
> storvsc_on_channel_callback is a void function and the return
> statement at the end is not useful.
>
> Found with checkpatch.
>
> Signed-off-by: Miguel Bernal Marin <[email protected]>

Reviewed-by: K. Y. Srinivasan <[email protected]>

> ---
> drivers/scsi/storvsc_drv.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 3d70d1cf49a3..538f3e131275 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1191,8 +1191,6 @@ static void storvsc_on_channel_callback(void
> *context)
> break;
> }
> } while (1);
> -
> - return;
> }
>
> static int storvsc_connect_to_vsp(struct hv_device *device, u32 ring_size,
> --
> 2.12.0