2020-06-09 09:52:36

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: 回复: [PATCH v2] us b: gadget : function: printer: fix use-after-free in __lock_acquire


A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Tue, Jun 09, 2020 at 09:35:11AM +0000, Zhang, Qiang wrote:
> Thank you for your suggestion
> two referenced counted objects in the same exact structure. another referenced is
> "dev->printer_cdev_open"?

Maybe, I don't know, but a cdev does have a reference count already,
right? Why do you need printer_cdev_open as well?

thanks,

greg k-h


2020-06-10 05:01:01

by Zhang, Qiang

[permalink] [raw]
Subject: 回复: 回复: [PATCH v2] usb: gadget: function: printer: fix use-after-free in __lock_acquir e

cdev object reference count and "struct printer_dev" object reference count(kref), This two reference counts do not conflict. in file usb-skeleton.c also used a similar method?? "struct usb_skel" contains kref members.

thanks,
Zqiang

________________________________________
??????: Greg KH <[email protected]>
????ʱ??: 2020??6??9?? 17:48
?ռ???: Zhang, Qiang
????: [email protected]; [email protected]; [email protected]
????: Re: ?ظ?: [PATCH v2] usb: gadget: function: printer: fix use-after-free in __lock_acquire


A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Tue, Jun 09, 2020 at 09:35:11AM +0000, Zhang, Qiang wrote:
> Thank you for your suggestion
> two referenced counted objects in the same exact structure. another referenced is
> "dev->printer_cdev_open"?

Maybe, I don't know, but a cdev does have a reference count already,
right? Why do you need printer_cdev_open as well?

thanks,

greg k-h

2020-06-18 08:31:05

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: 回复: 回复: [PATC H v2] usb: gadget : function: printer: fix use-after-free in __lock_acquire

On Wed, Jun 10, 2020 at 04:58:44AM +0000, Zhang, Qiang wrote:
> cdev object reference count and "struct printer_dev" object
> reference count(kref), This two reference counts do not conflict. in
> file usb-skeleton.c also used a similar method, "struct usb_skel"
> contains kref members.

I do not understand what you are referring to here, sorry.

greg k-h