2022-08-26 12:21:08

by Sandipan Patra

Subject: [PATCH 2/2] arm64: tegra: Add user PWM support on Jetson Orin

Enable in device tree and use it to drive the PWM controllers on
40 pin header of Orin dev-kit.

Signed-off-by: Sandipan Patra <[email protected]>
---
.../arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
index a85993c85e45..e76894574d32 100644
--- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
@@ -2,4 +2,18 @@

/ {
compatible = "nvidia,p3737-0000";
+
+ bus@0 {
+ pwm@3280000 {
+ status = "okay";
+ };
+
+ pwm@32c0000 {
+ status = "okay";
+ };
+
+ pwm@32f0000 {
+ status = "okay";
+ };
+ };
};
--
2.17.1

2022-08-26 17:45:56

by Krzysztof Kozlowski

Subject: Re: [PATCH 2/2] arm64: tegra: Add user PWM support on Jetson Orin

On 26/08/2022 15:17, Sandipan Patra wrote:
> Enable in device tree and use it to drive the PWM controllers on
> 40 pin header of Orin dev-kit.
>
> Signed-off-by: Sandipan Patra <[email protected]>
> ---
> .../arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
> index a85993c85e45..e76894574d32 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
> @@ -2,4 +2,18 @@
>
> / {
> compatible = "nvidia,p3737-0000";
> +
> + bus@0 {
> + pwm@3280000 {
> + status = "okay";
> + };

Overriding by node path is error-prone. You should override by label.

Best regards,
Krzysztof

2022-08-29 12:16:54

by Sandipan Patra

Subject: RE: [PATCH 2/2] arm64: tegra: Add user PWM support on Jetson Orin

> -----Original Message-----
> From: Krzysztof Kozlowski <[email protected]>
> Sent: Friday, August 26, 2022 11:05 PM
> To: Sandipan Patra <[email protected]>; [email protected];
> Jonathan Hunter <[email protected]>; [email protected];
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]
> Cc: Bibek Basu <[email protected]>; Krishna Yarlagadda
> <[email protected]>
> Subject: Re: [PATCH 2/2] arm64: tegra: Add user PWM support on Jetson
> Orin
>
> External email: Use caution opening links or attachments
>
>
> On 26/08/2022 15:17, Sandipan Patra wrote:
> > Enable in device tree and use it to drive the PWM controllers on
> > 40 pin header of Orin dev-kit.
> >
> > Signed-off-by: Sandipan Patra <[email protected]>
> > ---
> > .../arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
> b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
> > index a85993c85e45..e76894574d32 100644
> > --- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
> > +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
> > @@ -2,4 +2,18 @@
> >
> > / {
> > compatible = "nvidia,p3737-0000";
> > +
> > + bus@0 {
> > + pwm@3280000 {
> > + status = "okay";
> > + };
>
> Overriding by node path is error-prone. You should override by label.
ACK.

Thanks & Regards,
Sandipan

>
> Best regards,
> Krzysztof