Just a kindly reminder.
On Thu, Nov 19, 2020 at 9:19:37, Gustavo Pimentel <[email protected]>
wrote:
> This patch series adds a new driver called xData-pcie for the Synopsys
> DesignWare PCIe prototype.
>
> The driver configures and enables the Synopsys DesignWare PCIe traffic
> generator IP inside of prototype Endpoint which will generate upstream
> and downstream PCIe traffic. This allows to quickly test the PCIe link
> throughput speed and check is the prototype solution has some limitation
> or not.
>
> Cc: Derek Kiernan <[email protected]>
> Cc: Dragan Cvetic <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: Jonathan Corbet <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
>
> Changes:
> V2: Rework driver according to Greg Kroah-Hartman feedback
> V3: Fixed issues detected while running on 64 bits platforms
>
> Gustavo Pimentel (5):
> misc: Add Synopsys DesignWare xData IP driver
> misc: Add Synopsys DesignWare xData IP driver to Makefile
> misc: Add Synopsys DesignWare xData IP driver to Kconfig
> Documentation: misc-devices: Add Documentation for dw-xdata-pcie
> driver
> MAINTAINERS: Add Synopsys xData IP driver maintainer
>
> Documentation/misc-devices/dw-xdata-pcie.rst | 40 +++
> MAINTAINERS | 7 +
> drivers/misc/Kconfig | 11 +
> drivers/misc/Makefile | 1 +
> drivers/misc/dw-xdata-pcie.c | 379 +++++++++++++++++++++++++++
> 5 files changed, 438 insertions(+)
> create mode 100644 Documentation/misc-devices/dw-xdata-pcie.rst
> create mode 100644 drivers/misc/dw-xdata-pcie.c
>
> --
> 2.7.4
On Tue, Feb 02, 2021 at 08:51:10AM +0000, Gustavo Pimentel wrote:
> Just a kindly reminder.
reminder of what?
On Tue, Feb 2, 2021 at 10:11:21, Greg Kroah-Hartman
<[email protected]> wrote:
> On Tue, Feb 02, 2021 at 08:51:10AM +0000, Gustavo Pimentel wrote:
> > Just a kindly reminder.
>
> reminder of what?
To review the patch set. I've done the requested modifications, but I
didn't get any feedback if this patch series is fine or it needs
something more to have an ACK.
If some feedback was provided, please accept my apologies. My email
account was having some issues some time ago and I might not have
received some emails.
-Gustavo
On Tue, Feb 02, 2021 at 10:38:29AM +0000, Gustavo Pimentel wrote:
> On Tue, Feb 2, 2021 at 10:11:21, Greg Kroah-Hartman
> <[email protected]> wrote:
>
> > On Tue, Feb 02, 2021 at 08:51:10AM +0000, Gustavo Pimentel wrote:
> > > Just a kindly reminder.
> >
> > reminder of what?
>
> To review the patch set. I've done the requested modifications, but I
> didn't get any feedback if this patch series is fine or it needs
> something more to have an ACK.
I do not knwo, I don't see anything my my review queue, sorry.
> If some feedback was provided, please accept my apologies. My email
> account was having some issues some time ago and I might not have
> received some emails.
Check the archives please, that's what they are there for :)
greg k-h
On Tue, Feb 2, 2021 at 10:43:3, Greg Kroah-Hartman
<[email protected]> wrote:
> On Tue, Feb 02, 2021 at 10:38:29AM +0000, Gustavo Pimentel wrote:
> > On Tue, Feb 2, 2021 at 10:11:21, Greg Kroah-Hartman
> > <[email protected]> wrote:
> >
> > > On Tue, Feb 02, 2021 at 08:51:10AM +0000, Gustavo Pimentel wrote:
> > > > Just a kindly reminder.
> > >
> > > reminder of what?
> >
> > To review the patch set. I've done the requested modifications, but I
> > didn't get any feedback if this patch series is fine or it needs
> > something more to have an ACK.
>
> I do not knwo, I don't see anything my my review queue, sorry.
I've resend the patch series. Let's see if appears now ????
>
> > If some feedback was provided, please accept my apologies. My email
> > account was having some issues some time ago and I might not have
> > received some emails.
>
> Check the archives please, that's what they are there for :)
I have just checked, there isn't any feedback besides yours and Arnd
Bergmann.
Thank you Greg.
-Gustavo
>
> greg k-h
On Tue, Feb 02, 2021 at 04:58:50PM +0000, Gustavo Pimentel wrote:
> On Tue, Feb 2, 2021 at 10:43:3, Greg Kroah-Hartman
> <[email protected]> wrote:
>
> > On Tue, Feb 02, 2021 at 10:38:29AM +0000, Gustavo Pimentel wrote:
> > > On Tue, Feb 2, 2021 at 10:11:21, Greg Kroah-Hartman
> > > <[email protected]> wrote:
> > >
> > > > On Tue, Feb 02, 2021 at 08:51:10AM +0000, Gustavo Pimentel wrote:
> > > > > Just a kindly reminder.
> > > >
> > > > reminder of what?
> > >
> > > To review the patch set. I've done the requested modifications, but I
> > > didn't get any feedback if this patch series is fine or it needs
> > > something more to have an ACK.
> >
> > I do not knwo, I don't see anything my my review queue, sorry.
>
> I've resend the patch series. Let's see if appears now ????
>
> >
> > > If some feedback was provided, please accept my apologies. My email
> > > account was having some issues some time ago and I might not have
> > > received some emails.
> >
> > Check the archives please, that's what they are there for :)
>
> I have just checked, there isn't any feedback besides yours and Arnd
> Bergmann.
Did you incorporate our review?
greg k-h
On Tue, Feb 2, 2021 at 17:8:21, Greg Kroah-Hartman
<[email protected]> wrote:
> On Tue, Feb 02, 2021 at 04:58:50PM +0000, Gustavo Pimentel wrote:
> > On Tue, Feb 2, 2021 at 10:43:3, Greg Kroah-Hartman
> > <[email protected]> wrote:
> >
> > > On Tue, Feb 02, 2021 at 10:38:29AM +0000, Gustavo Pimentel wrote:
> > > > On Tue, Feb 2, 2021 at 10:11:21, Greg Kroah-Hartman
> > > > <[email protected]> wrote:
> > > >
> > > > > On Tue, Feb 02, 2021 at 08:51:10AM +0000, Gustavo Pimentel wrote:
> > > > > > Just a kindly reminder.
> > > > >
> > > > > reminder of what?
> > > >
> > > > To review the patch set. I've done the requested modifications, but I
> > > > didn't get any feedback if this patch series is fine or it needs
> > > > something more to have an ACK.
> > >
> > > I do not knwo, I don't see anything my my review queue, sorry.
> >
> > I've resend the patch series. Let's see if appears now ????
> >
> > >
> > > > If some feedback was provided, please accept my apologies. My email
> > > > account was having some issues some time ago and I might not have
> > > > received some emails.
> > >
> > > Check the archives please, that's what they are there for :)
> >
> > I have just checked, there isn't any feedback besides yours and Arnd
> > Bergmann.
>
> Did you incorporate our review?
Yes, I did. The driver initially was using the modules parameters, and
based on your feedback I changed to sysfs using other drivers'
implementation as a reference. I also the driver structure changed to use
macros instead of bitfields.
>
> greg k-h