2021-06-08 16:08:23

by Christoph Hellwig

Subject: [PATCH 01/16] mm: use kmap_local_page in memzero_page

No need for kmap_atomic here.

Signed-off-by: Christoph Hellwig <[email protected]>
---
include/linux/highmem.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/highmem.h b/include/linux/highmem.h
index 832b49b50c7b..0dc0451cf1d1 100644
--- a/include/linux/highmem.h
+++ b/include/linux/highmem.h
@@ -334,9 +334,9 @@ static inline void memcpy_to_page(struct page *page, size_t offset,

static inline void memzero_page(struct page *page, size_t offset, size_t len)
{
- char *addr = kmap_atomic(page);
+ char *addr = kmap_local_page(page);
memset(addr + offset, 0, len);
- kunmap_atomic(addr);
+ kunmap_local(addr);
}

#endif /* _LINUX_HIGHMEM_H */
--
2.30.2

2021-06-08 18:20:58

by Chaitanya Kulkarni

Subject: Re: [PATCH 01/16] mm: use kmap_local_page in memzero_page

On 6/8/21 09:06, Christoph Hellwig wrote:
> No need for kmap_atomic here.
>
> Signed-off-by: Christoph Hellwig <[email protected]>

Looks good.

Reviewed-by: Chaitanya Kulkarni <[email protected]>