2020-08-30 05:49:45

by Gal Hammer

Subject: [PATCH] igb: read PBA number from flash

Fixed flash presence check for 82576 controllers so the part
number string is read and displayed correctly.

Signed-off-by: Gal Hammer <[email protected]>
---
drivers/net/ethernet/intel/igb/igb_main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index d9c3a6b169f9..245e62b0a97e 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -3388,7 +3388,9 @@ static int igb_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
"Width x1" : "unknown"), netdev->dev_addr);
}

- if ((hw->mac.type >= e1000_i210 ||
+ if ((hw->mac.type == e1000_82576 &&
+ rd32(E1000_EECD) & E1000_EECD_PRES) ||
+ (hw->mac.type >= e1000_i210 ||
igb_get_flash_presence_i210(hw))) {
ret_val = igb_read_part_string(hw, part_str,
E1000_PBANUM_LENGTH);
--
2.26.2

2020-09-04 20:23:25

by Brown, Aaron F

Subject: RE: [PATCH] igb: read PBA number from flash

> From: Gal Hammer <[email protected]>
> Sent: Saturday, August 29, 2020 10:45 PM
> To: [email protected]
> Cc: Kirsher, Jeffrey T <[email protected]>; David S . Miller
> <[email protected]>; Jakub Kicinski <[email protected]>; intel-wired-
> [email protected]; [email protected]; Marcel Apfelbaum
> <[email protected]>; Gal Hammer <[email protected]>
> Subject: [PATCH] igb: read PBA number from flash
>
> Fixed flash presence check for 82576 controllers so the part
> number string is read and displayed correctly.
>
> Signed-off-by: Gal Hammer <[email protected]>
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Tested-by: Aaron Brown <[email protected]>