2023-08-01 08:45:44

by Ran Sun

Subject: [PATCH] drm/amdgpu: Clean up errors in vega20_baco.c

Fix the following errors reported by checkpatch:

ERROR: that open brace { should be on the previous line
ERROR: space required before the open parenthesis '('

Signed-off-by: Ran Sun <[email protected]>
---
drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
index 8d99c7a5abf8..994c0d374bfa 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
+++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
@@ -31,8 +31,7 @@

#include "amdgpu_ras.h"

-static const struct soc15_baco_cmd_entry clean_baco_tbl[] =
-{
+static const struct soc15_baco_cmd_entry clean_baco_tbl[] = {
{CMD_WRITE, SOC15_REG_ENTRY(NBIF, 0, mmBIOS_SCRATCH_6), 0, 0, 0, 0},
{CMD_WRITE, SOC15_REG_ENTRY(NBIF, 0, mmBIOS_SCRATCH_7), 0, 0, 0, 0},
};
@@ -90,11 +89,11 @@ int vega20_baco_set_state(struct pp_hwmgr *hwmgr, enum BACO_STATE state)
data |= 0x80000000;
WREG32_SOC15(THM, 0, mmTHM_BACO_CNTL, data);

- if(smum_send_msg_to_smc_with_parameter(hwmgr,
+ if (smum_send_msg_to_smc_with_parameter(hwmgr,
PPSMC_MSG_EnterBaco, 0, NULL))
return -EINVAL;
} else {
- if(smum_send_msg_to_smc_with_parameter(hwmgr,
+ if (smum_send_msg_to_smc_with_parameter(hwmgr,
PPSMC_MSG_EnterBaco, 1, NULL))
return -EINVAL;
}
--
2.17.1

2023-08-01 10:16:43

by Evan Quan

Subject: RE: [PATCH] drm/amdgpu: Clean up errors in vega20_baco.c

[AMD Official Use Only - General]

Reviewed-by: Evan Quan <[email protected]>

> -----Original Message-----
> From: amd-gfx <[email protected]> On Behalf Of Ran
> Sun
> Sent: Tuesday, August 1, 2023 4:03 PM
> To: Deucher, Alexander <[email protected]>; [email protected];
> [email protected]
> Cc: Ran Sun <[email protected]>; [email protected];
> [email protected]; [email protected]
> Subject: [PATCH] drm/amdgpu: Clean up errors in vega20_baco.c
>
> Fix the following errors reported by checkpatch:
>
> ERROR: that open brace { should be on the previous line
> ERROR: space required before the open parenthesis '('
>
> Signed-off-by: Ran Sun <[email protected]>
> ---
> drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
> b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
> index 8d99c7a5abf8..994c0d374bfa 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
> @@ -31,8 +31,7 @@
>
> #include "amdgpu_ras.h"
>
> -static const struct soc15_baco_cmd_entry clean_baco_tbl[] = -{
> +static const struct soc15_baco_cmd_entry clean_baco_tbl[] = {
> {CMD_WRITE, SOC15_REG_ENTRY(NBIF, 0, mmBIOS_SCRATCH_6), 0,
> 0, 0, 0},
> {CMD_WRITE, SOC15_REG_ENTRY(NBIF, 0, mmBIOS_SCRATCH_7), 0,
> 0, 0, 0}, }; @@ -90,11 +89,11 @@ int vega20_baco_set_state(struct
> pp_hwmgr *hwmgr, enum BACO_STATE state)
> data |= 0x80000000;
> WREG32_SOC15(THM, 0, mmTHM_BACO_CNTL,
> data);
>
> - if(smum_send_msg_to_smc_with_parameter(hwmgr,
> + if
> (smum_send_msg_to_smc_with_parameter(hwmgr,
> PPSMC_MSG_EnterBaco, 0, NULL))
> return -EINVAL;
> } else {
> - if(smum_send_msg_to_smc_with_parameter(hwmgr,
> + if
> (smum_send_msg_to_smc_with_parameter(hwmgr,
> PPSMC_MSG_EnterBaco, 1, NULL))
> return -EINVAL;
> }
> --
> 2.17.1

2023-08-07 18:25:55

by Alex Deucher

Subject: Re: [PATCH] drm/amdgpu: Clean up errors in vega20_baco.c

Applied. Thanks!

On Tue, Aug 1, 2023 at 5:25 AM Quan, Evan <[email protected]> wrote:
>
> [AMD Official Use Only - General]
>
> Reviewed-by: Evan Quan <[email protected]>
>
> > -----Original Message-----
> > From: amd-gfx <[email protected]> On Behalf Of Ran
> > Sun
> > Sent: Tuesday, August 1, 2023 4:03 PM
> > To: Deucher, Alexander <[email protected]>; [email protected];
> > [email protected]
> > Cc: Ran Sun <[email protected]>; [email protected];
> > [email protected]; [email protected]
> > Subject: [PATCH] drm/amdgpu: Clean up errors in vega20_baco.c
> >
> > Fix the following errors reported by checkpatch:
> >
> > ERROR: that open brace { should be on the previous line
> > ERROR: space required before the open parenthesis '('
> >
> > Signed-off-by: Ran Sun <[email protected]>
> > ---
> > drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c | 7 +++----
> > 1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
> > b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
> > index 8d99c7a5abf8..994c0d374bfa 100644
> > --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
> > +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
> > @@ -31,8 +31,7 @@
> >
> > #include "amdgpu_ras.h"
> >
> > -static const struct soc15_baco_cmd_entry clean_baco_tbl[] = -{
> > +static const struct soc15_baco_cmd_entry clean_baco_tbl[] = {
> > {CMD_WRITE, SOC15_REG_ENTRY(NBIF, 0, mmBIOS_SCRATCH_6), 0,
> > 0, 0, 0},
> > {CMD_WRITE, SOC15_REG_ENTRY(NBIF, 0, mmBIOS_SCRATCH_7), 0,
> > 0, 0, 0}, }; @@ -90,11 +89,11 @@ int vega20_baco_set_state(struct
> > pp_hwmgr *hwmgr, enum BACO_STATE state)
> > data |= 0x80000000;
> > WREG32_SOC15(THM, 0, mmTHM_BACO_CNTL,
> > data);
> >
> > - if(smum_send_msg_to_smc_with_parameter(hwmgr,
> > + if
> > (smum_send_msg_to_smc_with_parameter(hwmgr,
> > PPSMC_MSG_EnterBaco, 0, NULL))
> > return -EINVAL;
> > } else {
> > - if(smum_send_msg_to_smc_with_parameter(hwmgr,
> > + if
> > (smum_send_msg_to_smc_with_parameter(hwmgr,
> > PPSMC_MSG_EnterBaco, 1, NULL))
> > return -EINVAL;
> > }
> > --
> > 2.17.1
>