2020-11-01 14:41:07

by Tom Rix

Subject: [PATCH] scsi: bnx2fc: remove unneeded semicolon

From: Tom Rix <[email protected]>

A semicolon is not needed after a switch statement.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
index 6890bbe04a8c..a436adb6092d 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
+++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
@@ -2275,7 +2275,7 @@ static int bnx2fc_ctlr_enabled(struct fcoe_ctlr_device *cdev)
case FCOE_CTLR_UNUSED:
default:
return -ENOTSUPP;
- };
+ }
}

enum bnx2fc_create_link_state {
--
2.18.1

2020-11-02 04:48:20

by Saurav Kashyap

Subject: RE: [EXT] [PATCH] scsi: bnx2fc: remove unneeded semicolon

Hi Tom,

> -----Original Message-----
> From: [email protected] <[email protected]>
> Sent: Sunday, November 1, 2020 8:08 PM
> To: Saurav Kashyap <[email protected]>; Javed Hasan
> <[email protected]>; [email protected]; [email protected]
> Cc: GR-QLogic-Storage-Upstream <GR-QLogic-Storage-
> [email protected]>; [email protected]; linux-
> [email protected]; Tom Rix <[email protected]>
> Subject: [EXT] [PATCH] scsi: bnx2fc: remove unneeded semicolon
>
> External Email
>
> ----------------------------------------------------------------------
> From: Tom Rix <[email protected]>
>
> A semicolon is not needed after a switch statement.
>
> Signed-off-by: Tom Rix <[email protected]>
> ---
> drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> index 6890bbe04a8c..a436adb6092d 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> @@ -2275,7 +2275,7 @@ static int bnx2fc_ctlr_enabled(struct
> fcoe_ctlr_device *cdev)
> case FCOE_CTLR_UNUSED:
> default:
> return -ENOTSUPP;
> - };
> + }
> }

Thanks for a patch.

Reviewed-by: Saurav Kashyap <[email protected]>

Thanks,
~Saurav
>
> enum bnx2fc_create_link_state {
> --
> 2.18.1

2020-11-05 04:57:49

by Martin K. Petersen

Subject: Re: [PATCH] scsi: bnx2fc: remove unneeded semicolon

Tom,

> A semicolon is not needed after a switch statement.

Applied to 5.11/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2020-11-11 03:00:35

by Martin K. Petersen

Subject: Re: [PATCH] scsi: bnx2fc: remove unneeded semicolon

On Sun, 1 Nov 2020 06:38:12 -0800, [email protected] wrote:

> A semicolon is not needed after a switch statement.

Applied to 5.11/scsi-queue, thanks!

[1/1] scsi: bnx2fc: Remove unneeded semicolon
https://git.kernel.org/mkp/scsi/c/4a9435b7b04e

--
Martin K. Petersen Oracle Linux Engineering