2021-03-04 11:13:06

by Lee Jones

Subject: [PATCH 15/30] scsi: qla2xxx: qla_iocb: Replace __qla2x00_marker()'s missing underscores

Fixes the following W=1 kernel build warning(s):

drivers/scsi/qla2xxx/qla_iocb.c:508: warning: expecting prototype for qla2x00_marker(). Prototype was for __qla2x00_marker() instead

Cc: Nilesh Javali <[email protected]>
Cc: [email protected]
Cc: "James E.J. Bottomley" <[email protected]>
Cc: "Martin K. Petersen" <[email protected]>
Cc: [email protected]
Signed-off-by: Lee Jones <[email protected]>
---
drivers/scsi/qla2xxx/qla_iocb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c
index 8b41cbaf8535b..e765ee4ce162a 100644
--- a/drivers/scsi/qla2xxx/qla_iocb.c
+++ b/drivers/scsi/qla2xxx/qla_iocb.c
@@ -491,7 +491,7 @@ qla2x00_start_iocbs(struct scsi_qla_host *vha, struct req_que *req)
}

/**
- * qla2x00_marker() - Send a marker IOCB to the firmware.
+ * __qla2x00_marker() - Send a marker IOCB to the firmware.
* @vha: HA context
* @qpair: queue pair pointer
* @loop_id: loop ID
--
2.27.0

2021-03-04 23:24:38

by Nilesh Javali

Subject: RE: [EXT] [PATCH 15/30] scsi: qla2xxx: qla_iocb: Replace __qla2x00_marker()'s missing underscores

> -----Original Message-----
> From: Lee Jones <[email protected]>
> Sent: Wednesday, March 3, 2021 8:16 PM
> To: [email protected]
> Cc: [email protected]; Nilesh Javali <[email protected]>; GR-
> QLogic-Storage-Upstream <[email protected]>;
> James E.J. Bottomley <[email protected]>; Martin K. Petersen
> <[email protected]>; [email protected]
> Subject: [EXT] [PATCH 15/30] scsi: qla2xxx: qla_iocb: Replace
> __qla2x00_marker()'s missing underscores
>
> External Email
>
> ----------------------------------------------------------------------
> Fixes the following W=1 kernel build warning(s):
>
> drivers/scsi/qla2xxx/qla_iocb.c:508: warning: expecting prototype for
> qla2x00_marker(). Prototype was for __qla2x00_marker() instead
>
> Cc: Nilesh Javali <[email protected]>
> Cc: [email protected]
> Cc: "James E.J. Bottomley" <[email protected]>
> Cc: "Martin K. Petersen" <[email protected]>
> Cc: [email protected]
> Signed-off-by: Lee Jones <[email protected]>
> ---
> drivers/scsi/qla2xxx/qla_iocb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c
> index 8b41cbaf8535b..e765ee4ce162a 100644
> --- a/drivers/scsi/qla2xxx/qla_iocb.c
> +++ b/drivers/scsi/qla2xxx/qla_iocb.c
> @@ -491,7 +491,7 @@ qla2x00_start_iocbs(struct scsi_qla_host *vha, struct
> req_que *req)
> }
>
> /**
> - * qla2x00_marker() - Send a marker IOCB to the firmware.
> + * __qla2x00_marker() - Send a marker IOCB to the firmware.
> * @vha: HA context
> * @qpair: queue pair pointer
> * @loop_id: loop ID
> --
> 2.27.0

Lee,

Thanks for the patch.
Ack-by: Nilesh Javali <[email protected]>