On 19/10/2022 09:39, Ibrahim Tilki wrote:
> Devicetree binding documentation for Analog Devices MAX313XX RTCs
>
> Signed-off-by: Ibrahim Tilki <[email protected]>
> Signed-off-by: Zeynep Arslanbenzer <[email protected]>
> ---
> .../devicetree/bindings/rtc/adi,max313xx.yaml | 163 ++++++++++++++++++
> 1 file changed, 163 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/adi,max313xx.yaml
>
> diff --git a/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml b/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml
> new file mode 100644
> index 000000000..1aa491799
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml
> @@ -0,0 +1,163 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright 2022 Analog Devices Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/adi,max313xx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices MAX313XX series I2C RTC driver
Drop "driver" unless it is some hardware-related term.
> +
> +maintainers:
> + - Ibrahim Tilki <[email protected]>
> + - Zeynep Arslanbenzer <[email protected]>
> +
> +description: Bindings for the Analog Devices MAX313XX series RTCs.
Drop "Bindings for"
> +
> +properties:
> + compatible:
> + enum:
> + - adi,max31328
> + - adi,max31329
> + - adi,max31331
> + - adi,max31334
> + - adi,max31341
> + - adi,max31342
> + - adi,max31343
This looked familiar... and indeed it is.
https://lore.kernel.org/all/[email protected]/
Where is the changelog? What are the differences? How can we understand
what is happening here?
Best regards,
Krzysztof
On Wed, Oct 19, 2022 at 10:34:15AM -0400, Krzysztof Kozlowski wrote:
> On 19/10/2022 09:39, Ibrahim Tilki wrote:
> > Devicetree binding documentation for Analog Devices MAX313XX RTCs
> >
> > Signed-off-by: Ibrahim Tilki <[email protected]>
> > Signed-off-by: Zeynep Arslanbenzer <[email protected]>
> > ---
> > .../devicetree/bindings/rtc/adi,max313xx.yaml | 163 ++++++++++++++++++
> > 1 file changed, 163 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/rtc/adi,max313xx.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml b/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml
> > new file mode 100644
> > index 000000000..1aa491799
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml
> > @@ -0,0 +1,163 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +# Copyright 2022 Analog Devices Inc.
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/rtc/adi,max313xx.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Analog Devices MAX313XX series I2C RTC driver
>
> Drop "driver" unless it is some hardware-related term.
>
> > +
> > +maintainers:
> > + - Ibrahim Tilki <[email protected]>
> > + - Zeynep Arslanbenzer <[email protected]>
> > +
> > +description: Bindings for the Analog Devices MAX313XX series RTCs.
>
> Drop "Bindings for"
>
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - adi,max31328
> > + - adi,max31329
> > + - adi,max31331
> > + - adi,max31334
> > + - adi,max31341
> > + - adi,max31342
> > + - adi,max31343
>
> This looked familiar... and indeed it is.
>
> https://lore.kernel.org/all/[email protected]/
>
> Where is the changelog? What are the differences? How can we understand
> what is happening here?
>
I hope that other submission was an error; otherwise it tried to sneak in
the bindings for max313xx under an unrelated subject.
Guenter
> On Wed, Oct 19, 2022 at 10:34:15AM -0400, Krzysztof Kozlowski wrote:
> > On 19/10/2022 09:39, Ibrahim Tilki wrote:
> > > Devicetree binding documentation for Analog Devices MAX313XX RTCs
> > >
> > > Signed-off-by: Ibrahim Tilki <[email protected]>
> > > Signed-off-by: Zeynep Arslanbenzer <[email protected]>
> > > ---
> > > .../devicetree/bindings/rtc/adi,max313xx.yaml | 163 ++++++++++++++++++
> > > 1 file changed, 163 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/rtc/adi,max313xx.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml \
> > > b/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml new file mode 100644
> > > index 000000000..1aa491799
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml
> > > @@ -0,0 +1,163 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +# Copyright 2022 Analog Devices Inc.
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/rtc/adi,max313xx.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Analog Devices MAX313XX series I2C RTC driver
> >
> > Drop "driver" unless it is some hardware-related term.
> >
> > > +
> > > +maintainers:
> > > + - Ibrahim Tilki <[email protected]>
> > > + - Zeynep Arslanbenzer <[email protected]>
> > > +
> > > +description: Bindings for the Analog Devices MAX313XX series RTCs.
> >
> > Drop "Bindings for"
> >
> > > +
> > > +properties:
> > > + compatible:
> > > + enum:
> > > + - adi,max31328
> > > + - adi,max31329
> > > + - adi,max31331
> > > + - adi,max31334
> > > + - adi,max31341
> > > + - adi,max31342
> > > + - adi,max31343
> >
> > This looked familiar... and indeed it is.
> >
> > https://lore.kernel.org/all/[email protected]/
> >
> > Where is the changelog? What are the differences? How can we understand
> > what is happening here?
> >
>
> I hope that other submission was an error; otherwise it tried to sneak in
> the bindings for max313xx under an unrelated subject.
>
> Guenter
This binding was included in the v6 of max11410 patch by mistake and I
mentioned it in v8 cover letter:
https://lore.kernel.org/all/[email protected]/
I still addressed your comments but did not include a changelog since
this is the first patch of a new series.
I'm sorry for the confusion.
Ibrahim