On Fri, Jul 21, 2023 at 02:26:16PM +0800, [email protected] wrote:
> From: Boon Khai Ng <[email protected]>
>
> This patch is to add the dts setting for the MAC controller on
> synopsys 10G Ethernet MAC which allow the 10G MAC to turn on
> hardware accelerated VLAN stripping. Once the hardware accelerated
> VLAN stripping is turn on, the VLAN tag will be stripped by the
> 10G Ethernet MAC.
...
> Reviewed-by: Shevchenko Andriy <[email protected]>
This is wrong:
- I never reviewed DT bindings in all your series.
- My name for the patches is also wrong.
P.S. What I mentioned in the internal mail is that you can add my tag to
the code, and not to the DT. Sorry, I probably hadn't been clear.
--
With Best Regards,
Andy Shevchenko
> -----Original Message-----
> From: Shevchenko, Andriy <[email protected]>
> Sent: Friday, July 21, 2023 6:18 PM
> Cc: Giuseppe Cavallaro <[email protected]>; Alexandre Torgue
> <[email protected]>; Jose Abreu <[email protected]>;
> David S . Miller <[email protected]>; Eric Dumazet
> <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni
> <[email protected]>; Maxime Coquelin <[email protected]>;
> [email protected]; [email protected];
> [email protected]; [email protected]; Ng,
> Boon Khai <[email protected]>; Tham, Mun Yew
> <[email protected]>; Swee, Leong Ching
> <[email protected]>; G Thomas, Rohan
> <[email protected]>
> Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-
> bindings: net: snps,dwmac: Add description for rx-vlan-offload
>
> On Fri, Jul 21, 2023 at 02:26:16PM +0800, [email protected] wrote:
> > From: Boon Khai Ng <[email protected]>
> >
> > This patch is to add the dts setting for the MAC controller on
> > synopsys 10G Ethernet MAC which allow the 10G MAC to turn on hardware
> > accelerated VLAN stripping. Once the hardware accelerated VLAN
> > stripping is turn on, the VLAN tag will be stripped by the 10G
> > Ethernet MAC.
>
> ...
>
> > Reviewed-by: Shevchenko Andriy <[email protected]>
>
> This is wrong:
> - I never reviewed DT bindings in all your series.
> - My name for the patches is also wrong.
>
> P.S. What I mentioned in the internal mail is that you can add my tag to
> the code, and not to the DT. Sorry, I probably hadn't been clear.
>
My bad, sorry for interpreting the meaning wrongly, I will remove all the
"Reviewed-by" stamp from all the DT patches on the next update.
However I copied the Reviewed-by: from the previous email, your name
Shouldn't be wrong.
> --
> With Best Regards,
> Andy Shevchenko
>
On Fri, Jul 21, 2023 at 06:35:44PM +0300, Ng, Boon Khai wrote:
> > From: Shevchenko, Andriy <[email protected]>
> > Sent: Friday, July 21, 2023 6:18 PM
> > On Fri, Jul 21, 2023 at 02:26:16PM +0800, [email protected] wrote:
> > > From: Boon Khai Ng <[email protected]>
...
> > > Reviewed-by: Shevchenko Andriy <[email protected]>
> >
> > This is wrong:
> > - I never reviewed DT bindings in all your series.
> > - My name for the patches is also wrong.
> >
> > P.S. What I mentioned in the internal mail is that you can add my tag to
> > the code, and not to the DT. Sorry, I probably hadn't been clear.
>
> My bad, sorry for interpreting the meaning wrongly, I will remove all the
> "Reviewed-by" stamp from all the DT patches on the next update.
>
> However I copied the Reviewed-by: from the previous email, your name
> Shouldn't be wrong.
Oh, this is a bit messy. The address for the kernel work should be
Andy Shevchenko <[email protected]>
--
With Best Regards,
Andy Shevchenko
> -----Original Message-----
> From: Shevchenko, Andriy <[email protected]>
> Sent: Friday, July 21, 2023 11:49 PM
> To: Ng, Boon Khai <[email protected]>
> Cc: Giuseppe Cavallaro <[email protected]>; Alexandre Torgue
> <[email protected]>; Jose Abreu <[email protected]>;
> David S . Miller <[email protected]>; Eric Dumazet
> <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni
> <[email protected]>; Maxime Coquelin <[email protected]>;
> [email protected]; [email protected];
> [email protected]; [email protected]; Tham,
> Mun Yew <[email protected]>; Swee, Leong Ching
> <[email protected]>; G Thomas, Rohan
> <[email protected]>
> Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-
> bindings: net: snps,dwmac: Add description for rx-vlan-offload
>
> On Fri, Jul 21, 2023 at 06:35:44PM +0300, Ng, Boon Khai wrote:
> > > From: Shevchenko, Andriy <[email protected]>
> > > Sent: Friday, July 21, 2023 6:18 PM
> > > On Fri, Jul 21, 2023 at 02:26:16PM +0800, [email protected]
> wrote:
> > > > From: Boon Khai Ng <[email protected]>
>
> ...
>
> > > > Reviewed-by: Shevchenko Andriy <[email protected]>
> > >
> > > This is wrong:
> > > - I never reviewed DT bindings in all your series.
> > > - My name for the patches is also wrong.
> > >
> > > P.S. What I mentioned in the internal mail is that you can add my tag to
> > > the code, and not to the DT. Sorry, I probably hadn't been clear.
> >
> > My bad, sorry for interpreting the meaning wrongly, I will remove all
> > the "Reviewed-by" stamp from all the DT patches on the next update.
> >
> > However I copied the Reviewed-by: from the previous email, your name
> > Shouldn't be wrong.
>
> Oh, this is a bit messy. The address for the kernel work should be Andy
> Shevchenko <[email protected]>
>
Ah okay, got it. Will update that in the next patch.
> --
> With Best Regards,
> Andy Shevchenko
>