2023-10-20 16:05:18

by Cameron Williams

[permalink] [raw]
Subject: [PATCH v4 05/11] tty: 8250: Add support for Intashield IS-100

Add support for the Intashield IS-100 1 port serial card.

Cc: [email protected]
Signed-off-by: Cameron Williams <[email protected]>
---
v3 - v4:
Add Cc: tag.

v2 - v3:
Re-submit patch series using git send-email to make threading work.

v1 - v2:
This is a resubmission series for the patch series below. That series
was lots of changes sent to lots of maintainers, this series is just for
the tty/serial/8250 subsystem.

[1] https://lore.kernel.org/all/DU0PR02MB789950E64D808DB57E9D7312C4F8A@DU0PR02MB7899.eurprd02.prod.outlook.com/
[2] https://lore.kernel.org/all/DU0PR02MB7899DE53DFC900EFB50E53F2C4F8A@DU0PR02MB7899.eurprd02.prod.outlook.com/
[3] https://lore.kernel.org/all/DU0PR02MB7899033E7E81EAF3694BC20AC4F8A@DU0PR02MB7899.eurprd02.prod.outlook.com/
[4] https://lore.kernel.org/all/DU0PR02MB7899EABA8C3DCAC94DCC79D4C4F8A@DU0PR02MB7899.eurprd02.prod.outlook.com/

drivers/tty/serial/8250/8250_pci.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
index 1c46b65789c9..b0a632415d8e 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -4913,6 +4913,12 @@ static const struct pci_device_id serial_pci_tbl[] = {
0, 0,
pbn_b1_bt_1_115200 },

+ /*
+ * IntaShield IS-100
+ */
+ { PCI_VENDOR_ID_INTASHIELD, 0x0D60,
+ PCI_ANY_ID, PCI_ANY_ID, 0, 0,
+ pbn_b2_1_115200 },
/*
* IntaShield IS-200
*/
--
2.42.0


2023-10-24 09:42:27

by Ilpo Järvinen

[permalink] [raw]
Subject: Re: [PATCH v4 05/11] tty: 8250: Add support for Intashield IS-100

On Fri, 20 Oct 2023, Cameron Williams wrote:

> Add support for the Intashield IS-100 1 port serial card.
>
> Cc: [email protected]

Why is this cc stable? I think it should be dropped.

--
i.

> Signed-off-by: Cameron Williams <[email protected]>
> ---
> v3 - v4:
> Add Cc: tag.
>
> v2 - v3:
> Re-submit patch series using git send-email to make threading work.
>
> v1 - v2:
> This is a resubmission series for the patch series below. That series
> was lots of changes sent to lots of maintainers, this series is just for
> the tty/serial/8250 subsystem.
>
> [1] https://lore.kernel.org/all/DU0PR02MB789950E64D808DB57E9D7312C4F8A@DU0PR02MB7899.eurprd02.prod.outlook.com/
> [2] https://lore.kernel.org/all/DU0PR02MB7899DE53DFC900EFB50E53F2C4F8A@DU0PR02MB7899.eurprd02.prod.outlook.com/
> [3] https://lore.kernel.org/all/DU0PR02MB7899033E7E81EAF3694BC20AC4F8A@DU0PR02MB7899.eurprd02.prod.outlook.com/
> [4] https://lore.kernel.org/all/DU0PR02MB7899EABA8C3DCAC94DCC79D4C4F8A@DU0PR02MB7899.eurprd02.prod.outlook.com/
>
> drivers/tty/serial/8250/8250_pci.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
> index 1c46b65789c9..b0a632415d8e 100644
> --- a/drivers/tty/serial/8250/8250_pci.c
> +++ b/drivers/tty/serial/8250/8250_pci.c
> @@ -4913,6 +4913,12 @@ static const struct pci_device_id serial_pci_tbl[] = {
> 0, 0,
> pbn_b1_bt_1_115200 },
>
> + /*
> + * IntaShield IS-100
> + */
> + { PCI_VENDOR_ID_INTASHIELD, 0x0D60,
> + PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> + pbn_b2_1_115200 },
> /*
> * IntaShield IS-200
> */
>

2023-10-24 09:50:00

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v4 05/11] tty: 8250: Add support for Intashield IS-100

On Tue, Oct 24, 2023 at 12:41:38PM +0300, Ilpo J?rvinen wrote:
> On Fri, 20 Oct 2023, Cameron Williams wrote:
>
> > Add support for the Intashield IS-100 1 port serial card.
> >
> > Cc: [email protected]
>
> Why is this cc stable? I think it should be dropped.

It's a new device id, those are allowed for stable.

thanks,

greg k-h