2022-01-20 11:59:58

by Abel Vesa

[permalink] [raw]
Subject: [PATCH 1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards compatibility

Drop the i.MX8QXP backwards compatibility with i.MX7ULP since they
differ from clocks handling point of view.

Signed-off-by: Abel Vesa <[email protected]>
---
Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
index aa83cbf56d59..ff364bd0fbac 100644
--- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
+++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
@@ -20,11 +20,10 @@ properties:
- fsl,ls1021a-lpuart
- fsl,ls1028a-lpuart
- fsl,imx7ulp-lpuart
+ - fsl,imx8qxp-lpuart
- fsl,imxrt1050-lpuart
- items:
- - enum:
- - fsl,imx8qxp-lpuart
- - fsl,imx8ulp-lpuart
+ - const: fsl,imx8ulp-lpuart
- const: fsl,imx7ulp-lpuart
- items:
- enum:
--
2.31.1


2022-01-20 12:00:02

by Abel Vesa

[permalink] [raw]
Subject: [PATCH 2/2] arm64: dts: imx8qxp-ss-adma: Drop fsl,imx7ulp-lpuart comaptible

The driver differs from clocks point of view, so the i.MX8QXP
is not backwards compatible with i.MX7ULP.

Signed-off-by: Abel Vesa <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8qxp-ss-adma.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-ss-adma.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp-ss-adma.dtsi
index dc1daa8dc72f..7bae516004bf 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp-ss-adma.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qxp-ss-adma.dtsi
@@ -5,19 +5,19 @@
*/

&lpuart0 {
- compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+ compatible = "fsl,imx8qxp-lpuart";
};

&lpuart1 {
- compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+ compatible = "fsl,imx8qxp-lpuart";
};

&lpuart2 {
- compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+ compatible = "fsl,imx8qxp-lpuart";
};

&lpuart3 {
- compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+ compatible = "fsl,imx8qxp-lpuart";
};

&i2c0 {
--
2.31.1

2022-01-21 13:56:23

by Peng Fan

[permalink] [raw]
Subject: RE: [PATCH 2/2] arm64: dts: imx8qxp-ss-adma: Drop fsl,imx7ulp-lpuart comaptible

> Subject: [PATCH 2/2] arm64: dts: imx8qxp-ss-adma: Drop fsl,imx7ulp-lpuart
> comaptible
>
> The driver differs from clocks point of view, so the i.MX8QXP is not backwards
> compatible with i.MX7ULP.
>
> Signed-off-by: Abel Vesa <[email protected]>

Reviewed-by: Peng Fan <[email protected]>

> ---
> arch/arm64/boot/dts/freescale/imx8qxp-ss-adma.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-ss-adma.dtsi
> b/arch/arm64/boot/dts/freescale/imx8qxp-ss-adma.dtsi
> index dc1daa8dc72f..7bae516004bf 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp-ss-adma.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp-ss-adma.dtsi
> @@ -5,19 +5,19 @@
> */
>
> &lpuart0 {
> - compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
> + compatible = "fsl,imx8qxp-lpuart";
> };
>
> &lpuart1 {
> - compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
> + compatible = "fsl,imx8qxp-lpuart";
> };
>
> &lpuart2 {
> - compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
> + compatible = "fsl,imx8qxp-lpuart";
> };
>
> &lpuart3 {
> - compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
> + compatible = "fsl,imx8qxp-lpuart";
> };
>
> &i2c0 {
> --
> 2.31.1

2022-01-21 13:57:09

by Peng Fan

[permalink] [raw]
Subject: RE: [PATCH 1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards compatibility

> Subject: [PATCH 1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards
> compatibility
>
> Drop the i.MX8QXP backwards compatibility with i.MX7ULP since they differ
> from clocks handling point of view.
>
> Signed-off-by: Abel Vesa <[email protected]>

Reviewed-by: Peng Fan <[email protected]>

> ---
> Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> index aa83cbf56d59..ff364bd0fbac 100644
> --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> @@ -20,11 +20,10 @@ properties:
> - fsl,ls1021a-lpuart
> - fsl,ls1028a-lpuart
> - fsl,imx7ulp-lpuart
> + - fsl,imx8qxp-lpuart
> - fsl,imxrt1050-lpuart
> - items:
> - - enum:
> - - fsl,imx8qxp-lpuart
> - - fsl,imx8ulp-lpuart
> + - const: fsl,imx8ulp-lpuart
> - const: fsl,imx7ulp-lpuart
> - items:
> - enum:
> --
> 2.31.1

2022-01-31 23:06:34

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH 2/2] arm64: dts: imx8qxp-ss-adma: Drop fsl,imx7ulp-lpuart comaptible

On Tue, Jan 18, 2022 at 03:59:18PM +0200, Abel Vesa wrote:
> The driver differs from clocks point of view, so the i.MX8QXP
> is not backwards compatible with i.MX7ULP.
>
> Signed-off-by: Abel Vesa <[email protected]>

Applied, thanks!

2022-02-09 04:07:01

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards compatibility

On Tue, 18 Jan 2022 15:59:17 +0200, Abel Vesa wrote:
> Drop the i.MX8QXP backwards compatibility with i.MX7ULP since they
> differ from clocks handling point of view.
>
> Signed-off-by: Abel Vesa <[email protected]>
> ---
> Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>

Acked-by: Rob Herring <[email protected]>

2022-02-09 13:46:44

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards compatibility

On Tue, Jan 18, 2022 at 03:59:17PM +0200, Abel Vesa wrote:
> Drop the i.MX8QXP backwards compatibility with i.MX7ULP since they
> differ from clocks handling point of view.
>
> Signed-off-by: Abel Vesa <[email protected]>

I tried to pick up the patch, but it failed to apply to my imx/bindings
branch. Could you rebase?

Shawn

> ---
> Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> index aa83cbf56d59..ff364bd0fbac 100644
> --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> @@ -20,11 +20,10 @@ properties:
> - fsl,ls1021a-lpuart
> - fsl,ls1028a-lpuart
> - fsl,imx7ulp-lpuart
> + - fsl,imx8qxp-lpuart
> - fsl,imxrt1050-lpuart
> - items:
> - - enum:
> - - fsl,imx8qxp-lpuart
> - - fsl,imx8ulp-lpuart
> + - const: fsl,imx8ulp-lpuart
> - const: fsl,imx7ulp-lpuart
> - items:
> - enum:
> --
> 2.31.1
>

2022-02-09 16:27:35

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards compatibility

On Wed, Feb 9, 2022 at 12:50 AM Shawn Guo <[email protected]> wrote:
>
> On Tue, Jan 18, 2022 at 03:59:17PM +0200, Abel Vesa wrote:
> > Drop the i.MX8QXP backwards compatibility with i.MX7ULP since they
> > differ from clocks handling point of view.
> >
> > Signed-off-by: Abel Vesa <[email protected]>
>
> I tried to pick up the patch, but it failed to apply to my imx/bindings
> branch. Could you rebase?

Shouldn't Greg be picking this up?

Rob

2022-02-11 00:09:36

by Abel Vesa

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards compatibility

On 22-01-18 15:59:17, Abel Vesa wrote:
> Drop the i.MX8QXP backwards compatibility with i.MX7ULP since they
> differ from clocks handling point of view.
>
> Signed-off-by: Abel Vesa <[email protected]>

Please ignore this one and have a look at the V2 here:

https://lore.kernel.org/lkml/[email protected]/raw

> ---
> Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> index aa83cbf56d59..ff364bd0fbac 100644
> --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> @@ -20,11 +20,10 @@ properties:
> - fsl,ls1021a-lpuart
> - fsl,ls1028a-lpuart
> - fsl,imx7ulp-lpuart
> + - fsl,imx8qxp-lpuart
> - fsl,imxrt1050-lpuart
> - items:
> - - enum:
> - - fsl,imx8qxp-lpuart
> - - fsl,imx8ulp-lpuart
> + - const: fsl,imx8ulp-lpuart
> - const: fsl,imx7ulp-lpuart
> - items:
> - enum:
> --
> 2.31.1
>