2023-09-14 12:17:41

by Krzysztof Kozlowski

Subject: Re: [PATCH 5/5] arm64: dts: imx93: update gpio node

On 14/09/2023 04:21, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> Per binding doc, i.MX93 GPIO supports two interrupts, and not
> compatible with i.MX7ULP. So update the node
>
> Signed-off-by: Peng Fan <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/imx93.dtsi | 20 ++++++++++++--------
> 1 file changed, 12 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index 6f85a05ee7e1..011c34a57c53 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -825,11 +825,12 @@ usdhc3: mmc@428b0000 {
> };
>
> gpio2: gpio@43810080 {
> - compatible = "fsl,imx93-gpio", "fsl,imx7ulp-gpio";
> + compatible = "fsl,imx93-gpio", "fsl,imx8ulp-gpio";

As your driver change points, it is breaking users, so no :(

Best regards,
Krzysztof

2023-09-14 16:13:34

by Peng Fan

Subject: RE: [PATCH 5/5] arm64: dts: imx93: update gpio node

> Subject: Re: [PATCH 5/5] arm64: dts: imx93: update gpio node
>
> On 14/09/2023 04:21, Peng Fan (OSS) wrote:
> > From: Peng Fan <[email protected]>
> >
> > Per binding doc, i.MX93 GPIO supports two interrupts, and not
> > compatible with i.MX7ULP. So update the node
> >
> > Signed-off-by: Peng Fan <[email protected]>
> > ---
> > arch/arm64/boot/dts/freescale/imx93.dtsi | 20 ++++++++++++--------
> > 1 file changed, 12 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi
> > b/arch/arm64/boot/dts/freescale/imx93.dtsi
> > index 6f85a05ee7e1..011c34a57c53 100644
> > --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> > @@ -825,11 +825,12 @@ usdhc3: mmc@428b0000 {
> > };
> >
> > gpio2: gpio@43810080 {
> > - compatible = "fsl,imx93-gpio", "fsl,imx7ulp-gpio";
> > + compatible = "fsl,imx93-gpio", "fsl,imx8ulp-gpio";
>
> As your driver change points, it is breaking users, so no :(

ok. Although i.MX93 GPIO is not compatible with i.MX7ULP from HW
perspective, the compatible string should keep as it is now and binding
doc keep as it is now?

Thanks,
Peng

>
> Best regards,
> Krzysztof