From: Peng Fan <[email protected]>
Using dev_err to show error message will make life easier.
Signed-off-by: Peng Fan <[email protected]>
---
drivers/gpio/gpiolib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index ce94e37bcbee..37fe9db0bd74 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -4233,7 +4233,7 @@ struct gpio_desc *gpiod_find_and_request(struct device *consumer,
ret = gpiod_configure_flags(desc, con_id, lookupflags, flags);
if (ret < 0) {
- dev_dbg(consumer, "setup of GPIO %s failed\n", con_id);
+ dev_err(consumer, "setup of GPIO %s failed: %d\n", con_id, ret);
gpiod_put(desc);
return ERR_PTR(ret);
}
--
2.37.1
On Fri, Mar 15, 2024 at 3:02 AM Peng Fan (OSS) <[email protected]> wrote:
>
> From: Peng Fan <[email protected]>
>
> Using dev_err to show error message will make life easier.
dev_err()
an error
..
It's unclear what the use case is and how this does make life easier.
We need to know more!
--
With Best Regards,
Andy Shevchenko
> Subject: Re: [PATCH] gpiolib: use dev_err when gpiod_configure_flags failed
>
> On Fri, Mar 15, 2024 at 3:02 AM Peng Fan (OSS) <[email protected]>
> wrote:
> >
> > From: Peng Fan <[email protected]>
> >
> > Using dev_err to show error message will make life easier.
>
> dev_err()
>
> an error
>
> ...
>
> It's unclear what the use case is and how this does make life easier.
> We need to know more!
I forgot to add gpio-ranges in gpio node, then it always fail in my driver
probe to configure pinctrl. So if using dev_err(), it will be easier for
me to locate the error point.
Thanks,
Peng.
>
> --
> With Best Regards,
> Andy Shevchenko
On Mon, Mar 18, 2024 at 02:03:12AM +0000, Peng Fan wrote:
> > Subject: Re: [PATCH] gpiolib: use dev_err when gpiod_configure_flags failed
> > On Fri, Mar 15, 2024 at 3:02 AM Peng Fan (OSS) <[email protected]>
> > wrote:
..
> > It's unclear what the use case is and how this does make life easier.
> > We need to know more!
>
> I forgot to add gpio-ranges in gpio node, then it always fail in my driver
> probe to configure pinctrl. So if using dev_err(), it will be easier for
> me to locate the error point.
At least make sure something like the above is in the commit message of the
next version.
--
With Best Regards,
Andy Shevchenko