From: Peng Fan <[email protected]>
Support i.MX93 Anatop which generates PLL and feeds into CCM.
Signed-off-by: Peng Fan <[email protected]>
---
.../bindings/clock/fsl,imx93-anatop.yaml | 41 +++++++++++++++++++
1 file changed, 41 insertions(+)
create mode 100644 Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
diff --git a/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml b/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
new file mode 100644
index 000000000000..9585c9e4ee40
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
@@ -0,0 +1,41 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/fsl,imx93-anatop.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP i.MX93 Anatop Module
+
+maintainers:
+ - Peng Fan <[email protected]>
+
+description: |
+ NXP i.MX93 anatop PLL module which generates PLL to CCM root.
+
+properties:
+ compatible:
+ items:
+ - const: fsl,imx93-anatop
+
+ reg:
+ maxItems: 1
+
+ '#clock-cells':
+ const: 1
+
+required:
+ - compatible
+ - reg
+ - '#clock-cells'
+
+additionalProperties: false
+
+examples:
+ - |
+ anatop: clock-controller@44480000 {
+ compatible = "fsl,imx93-anatop";
+ reg = <0x44480000 0x2000>;
+ #clock-cells = <1>;
+ };
+
+...
--
2.37.1
From: Peng Fan <[email protected]>
The anatop module actually generates PLL to CCM. Since the
binding doc has been updated to clock-controller for this module,
Let's also update the device tree node.
Signed-off-by: Peng Fan <[email protected]>
---
arch/arm64/boot/dts/freescale/imx93.dtsi | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index ceccf4766440..4e7a51ae743d 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -422,9 +422,10 @@ mediamix: power-domain@44462400 {
};
};
- anatop: anatop@44480000 {
- compatible = "fsl,imx93-anatop", "syscon";
+ anatop: clock-controller@44480000 {
+ compatible = "fsl,imx93-anatop";
reg = <0x44480000 0x2000>;
+ #clock-cells = <1>;
};
tmu: tmu@44482000 {
--
2.37.1
On Wed, Oct 18, 2023 at 04:44:13PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> Support i.MX93 Anatop which generates PLL and feeds into CCM.
What is "CCM". How do you "generate" a PLL?
> Signed-off-by: Peng Fan <[email protected]>
> ---
> .../bindings/clock/fsl,imx93-anatop.yaml | 41 +++++++++++++++++++
> 1 file changed, 41 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
>
> diff --git a/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml b/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
> new file mode 100644
> index 000000000000..9585c9e4ee40
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/fsl,imx93-anatop.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP i.MX93 Anatop Module
I see there are also "anatop regulators" on some imx SoCs, just calling
this "anatop module" does not seem sufficiently descriptive.
> +
> +maintainers:
> + - Peng Fan <[email protected]>
> +
> +description: |
Drop the |, you don't need it.
> + NXP i.MX93 anatop PLL module which generates PLL to CCM root.
> +
> +properties:
> + compatible:
> + items:
> + - const: fsl,imx93-anatop
> +
> + reg:
> + maxItems: 1
> +
> + '#clock-cells':
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - '#clock-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + anatop: clock-controller@44480000 {
and the label is is not used, so should be dropped.
Thanks,
Conor.
> + compatible = "fsl,imx93-anatop";
> + reg = <0x44480000 0x2000>;
> + #clock-cells = <1>;
> + };
> +
> +...
> --
> 2.37.1
>
> Subject: Re: [PATCH 1/2] dt-bindings: clock: support i.MX93 Anatop
>
> On Wed, Oct 18, 2023 at 04:44:13PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <[email protected]>
> >
> > Support i.MX93 Anatop which generates PLL and feeds into CCM.
>
> What is "CCM". How do you "generate" a PLL?
CCM: Clock Controller Module.
I may use produces PLL
>
> > Signed-off-by: Peng Fan <[email protected]>
> > ---
> > .../bindings/clock/fsl,imx93-anatop.yaml | 41 +++++++++++++++++++
> > 1 file changed, 41 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
> > b/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
> > new file mode 100644
> > index 000000000000..9585c9e4ee40
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
> > @@ -0,0 +1,41 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/fsl,imx93-anatop.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: NXP i.MX93 Anatop Module
>
> I see there are also "anatop regulators" on some imx SoCs, just calling this
> "anatop module" does not seem sufficiently descriptive.
Analog Module? How do you think?
>
> > +
> > +maintainers:
> > + - Peng Fan <[email protected]>
> > +
> > +description: |
>
> Drop the |, you don't need it.
Ok.
>
> > + NXP i.MX93 anatop PLL module which generates PLL to CCM root.
> > +
> > +properties:
> > + compatible:
> > + items:
> > + - const: fsl,imx93-anatop
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + '#clock-cells':
> > + const: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - '#clock-cells'
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + anatop: clock-controller@44480000 {
>
> and the label is is not used, so should be dropped.
Ok.
Thanks,
Peng.
>
> Thanks,
> Conor.
>
> > + compatible = "fsl,imx93-anatop";
> > + reg = <0x44480000 0x2000>;
> > + #clock-cells = <1>;
> > + };
> > +
> > +...
> > --
> > 2.37.1
> >
On Thu, Oct 19, 2023 at 10:05:54AM +0000, Peng Fan wrote:
> > Subject: Re: [PATCH 1/2] dt-bindings: clock: support i.MX93 Anatop
> >
> > On Wed, Oct 18, 2023 at 04:44:13PM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <[email protected]>
> > >
> > > Support i.MX93 Anatop which generates PLL and feeds into CCM.
> >
> > What is "CCM". How do you "generate" a PLL?
>
>
> CCM: Clock Controller Module.
> I may use produces PLL
No, almost certainly it _is_ a PLL and produces a clock.
> > > Signed-off-by: Peng Fan <[email protected]>
> > > ---
> > > .../bindings/clock/fsl,imx93-anatop.yaml | 41 +++++++++++++++++++
> > > 1 file changed, 41 insertions(+)
> > > create mode 100644
> > > Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
> > > b/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
> > > new file mode 100644
> > > index 000000000000..9585c9e4ee40
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
> > > @@ -0,0 +1,41 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/clock/fsl,imx93-anatop.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: NXP i.MX93 Anatop Module
> >
> > I see there are also "anatop regulators" on some imx SoCs, just calling this
> > "anatop module" does not seem sufficiently descriptive.
>
> Analog Module? How do you think?
It'd probably more be descriptive, but really putting the PLL bit in the
title would be helpful.
I assume "anatop" is what this thing is called in the RTL for the
device.
Cheers,
Conor.
>
> >
> > > +
> > > +maintainers:
> > > + - Peng Fan <[email protected]>
> > > +
> > > +description: |
> >
> > Drop the |, you don't need it.
>
> Ok.
>
> >
> > > + NXP i.MX93 anatop PLL module which generates PLL to CCM root.
> > > +
> > > +properties:
> > > + compatible:
> > > + items:
> > > + - const: fsl,imx93-anatop
> > > +
> > > + reg:
> > > + maxItems: 1
> > > +
> > > + '#clock-cells':
> > > + const: 1
> > > +
> > > +required:
> > > + - compatible
> > > + - reg
> > > + - '#clock-cells'
> > > +
> > > +additionalProperties: false
> > > +
> > > +examples:
> > > + - |
> > > + anatop: clock-controller@44480000 {
> >
> > and the label is is not used, so should be dropped.
>
> Ok.
>
> Thanks,
> Peng.
>
> >
> > Thanks,
> > Conor.
> >
> > > + compatible = "fsl,imx93-anatop";
> > > + reg = <0x44480000 0x2000>;
> > > + #clock-cells = <1>;
> > > + };
> > > +
> > > +...
> > > --
> > > 2.37.1
> > >
On Thu, Oct 19, 2023 at 11:28:43AM -0300, Estevam Moreira wrote:
> Remove me.
> I don't know what It is.
It is a typo! Someone meant to CC "[email protected]" and omitted the
f.
Peng Fan, please be more careful - your anatop series also CCed
"[email protected]".