2023-03-23 11:27:53

by Peng Fan (OSS)

Subject: [PATCH] arm64: dts: imx8mn-evk: update i2c pinctrl to match dtschema

From: Peng Fan <[email protected]>

The dtschema requires 'grp' in the end, so update the name.

Signed-off-by: Peng Fan <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
index 8fef980c4ab2..876eb5da5e2d 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
@@ -389,7 +389,7 @@ MX8MN_IOMUXC_I2C2_SDA_I2C2_SDA 0x400001c3
>;
};

- pinctrl_i2c2_gpio: i2c2grp-gpio {
+ pinctrl_i2c2_gpio: i2c2gpriogrp {
fsl,pins = <
MX8MN_IOMUXC_I2C2_SCL_GPIO5_IO16 0x1c3
MX8MN_IOMUXC_I2C2_SDA_GPIO5_IO17 0x1c3
@@ -403,7 +403,7 @@ MX8MN_IOMUXC_I2C3_SDA_I2C3_SDA 0x400001c3
>;
};

- pinctrl_i2c3_gpio: i2c3grp-gpio {
+ pinctrl_i2c3_gpio: i2c3gpiogrp {
fsl,pins = <
MX8MN_IOMUXC_I2C3_SCL_GPIO5_IO18 0x1c3
MX8MN_IOMUXC_I2C3_SDA_GPIO5_IO19 0x1c3
--
2.37.1

2023-03-27 05:37:39

by Shawn Guo

Subject: Re: [PATCH] arm64: dts: imx8mn-evk: update i2c pinctrl to match dtschema

On Thu, Mar 23, 2023 at 07:19:24PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> The dtschema requires 'grp' in the end, so update the name.
>
> Signed-off-by: Peng Fan <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
> index 8fef980c4ab2..876eb5da5e2d 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
> @@ -389,7 +389,7 @@ MX8MN_IOMUXC_I2C2_SDA_I2C2_SDA 0x400001c3
> >;
> };
>
> - pinctrl_i2c2_gpio: i2c2grp-gpio {
> + pinctrl_i2c2_gpio: i2c2gpriogrp {

i2c2gpiogrp

Shawn

> fsl,pins = <
> MX8MN_IOMUXC_I2C2_SCL_GPIO5_IO16 0x1c3
> MX8MN_IOMUXC_I2C2_SDA_GPIO5_IO17 0x1c3
> @@ -403,7 +403,7 @@ MX8MN_IOMUXC_I2C3_SDA_I2C3_SDA 0x400001c3
> >;
> };
>
> - pinctrl_i2c3_gpio: i2c3grp-gpio {
> + pinctrl_i2c3_gpio: i2c3gpiogrp {
> fsl,pins = <
> MX8MN_IOMUXC_I2C3_SCL_GPIO5_IO18 0x1c3
> MX8MN_IOMUXC_I2C3_SDA_GPIO5_IO19 0x1c3
> --
> 2.37.1
>

2023-03-27 10:04:55

by Peng Fan

Subject: RE: [PATCH] arm64: dts: imx8mn-evk: update i2c pinctrl to match dtschema

Shawn,

> Subject: Re: [PATCH] arm64: dts: imx8mn-evk: update i2c pinctrl to match
> dtschema
>
> On Thu, Mar 23, 2023 at 07:19:24PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <[email protected]>
> >
> > The dtschema requires 'grp' in the end, so update the name.
> >
> > Signed-off-by: Peng Fan <[email protected]>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
> > index 8fef980c4ab2..876eb5da5e2d 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
> > @@ -389,7 +389,7 @@ MX8MN_IOMUXC_I2C2_SDA_I2C2_SDA
> 0x400001c3
> > >;
> > };
> >
> > - pinctrl_i2c2_gpio: i2c2grp-gpio {
> > + pinctrl_i2c2_gpio: i2c2gpriogrp {
>
> i2c2gpiogrp

Sorry, I not get your point, I already use i2c2gpiogrp.

Thanks,
Peng.

>
> Shawn
>
> > fsl,pins = <
> > MX8MN_IOMUXC_I2C2_SCL_GPIO5_IO16
> 0x1c3
> > MX8MN_IOMUXC_I2C2_SDA_GPIO5_IO17
> 0x1c3
> > @@ -403,7 +403,7 @@ MX8MN_IOMUXC_I2C3_SDA_I2C3_SDA
> 0x400001c3
> > >;
> > };
> >
> > - pinctrl_i2c3_gpio: i2c3grp-gpio {
> > + pinctrl_i2c3_gpio: i2c3gpiogrp {
> > fsl,pins = <
> > MX8MN_IOMUXC_I2C3_SCL_GPIO5_IO18
> 0x1c3
> > MX8MN_IOMUXC_I2C3_SDA_GPIO5_IO19
> 0x1c3
> > --
> > 2.37.1
> >

2023-03-27 10:23:43

by Fabio Estevam

Subject: Re: [PATCH] arm64: dts: imx8mn-evk: update i2c pinctrl to match dtschema

Hi Peng,

On Mon, Mar 27, 2023 at 7:00 AM Peng Fan <[email protected]> wrote:

> > i2c2gpiogrp
>
> Sorry, I not get your point, I already use i2c2gpiogrp.

What Shawn meant is that there was a typo in your patch.

You wrote i2c2gpriogrp instead of i2c2gpiogrp.