2002-01-05 09:46:58

by Adam J. Richter

[permalink] [raw]
Subject: Patch: linux-2.5.2-pre6/drivers/message/i2o/i2o_block.c compilation fixes

The following patch fixes various compilation errors in
linux-2.5.2-pre8/drivers/message/i2o/i2o_block.c, related to
kdev_t and the new spinlock parameter to blk_init_queue.
It might be a good idea for someone to look at the spinlocks
that I created for blk_init_queue in this patch and tell me if
I botched it.

As is the case with the other patches that I have been
submitted for the past couple of days, I only know that this code
compiles. It has not been otherwise tested.

--
Adam J. Richter __ ______________ 4880 Stevens Creek Blvd, Suite 104
[email protected] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631 "Free Software For The Rest Of Us."


Attachments:
(No filename) (771.00 B)
i2o.diff (9.53 kB)
Download all attachments

2002-01-05 17:25:03

by Alan

[permalink] [raw]
Subject: Re: Patch: linux-2.5.2-pre6/drivers/message/i2o/i2o_block.c compilation fixes

> The following patch fixes various compilation errors in
> linux-2.5.2-pre8/drivers/message/i2o/i2o_block.c, related to
> kdev_t and the new spinlock parameter to blk_init_queue.
> It might be a good idea for someone to look at the spinlocks
> that I created for blk_init_queue in this patch and tell me if
> I botched it.

Unless you have i2o hardware please leave that code alone. It just creates
more maintenance nightmares. I2O on 2.5.x is broken anyway and will oops
when loaded with or without you changes. I know about this. I will look at
it once the block layer changes are stable.

There are 32/64bit bugs, endian assumptions, and the complete absence of the
use of the PCI dma API to deal with too.