2002-03-08 18:34:06

by Paul Menage

Subject: [PATCH] Bug in set_fs_altroot()

There's a missing '!' in set_fs_altroot():

--- linux-2.5.6/fs/namei.c~ Fri Mar 8 10:21:38 2002
+++ linux-2.5.6/fs/namei.c Fri Mar 8 10:26:36 2002
@@ -761,7 +761,7 @@
if (!emul)
goto set_it;
err = path_lookup(emul, LOOKUP_FOLLOW|LOOKUP_DIRECTORY|LOOKUP_NOALT, &nd);
- if (err) {
+ if (!err) {
mnt = nd.mnt;
dentry = nd.dentry;
}

2002-03-08 23:51:15

by Alexander Viro

Subject: Re: [PATCH] Bug in set_fs_altroot()

On Fri, 8 Mar 2002, Paul Menage wrote:

>
> There's a missing '!' in set_fs_altroot():

Sigh... That was not my week ;-/

Linus, please apply.

> --- linux-2.5.6/fs/namei.c~ Fri Mar 8 10:21:38 2002
> +++ linux-2.5.6/fs/namei.c Fri Mar 8 10:26:36 2002
> @@ -761,7 +761,7 @@
> if (!emul)
> goto set_it;
> err = path_lookup(emul, LOOKUP_FOLLOW|LOOKUP_DIRECTORY|LOOKUP_NOALT, &nd);
> - if (err) {
> + if (!err) {
> mnt = nd.mnt;
> dentry = nd.dentry;
> }
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>