2002-08-22 23:43:50

by Anton Altaparmakov

[permalink] [raw]
Subject: [BK-2.4 PATCH] Fix compile with highmem and highio

Hi Marcelo,

Below patchlet is required to make your current bk tree compile with
highmem and highio enabled.

Please apply.

You can also get this changeset by doing a:

bk pull http://linux-ntfs.bkbits.net/linux-2.4-kmapfix

Best regards,

Anton
--
Anton Altaparmakov <aia21 at cantab.net> (replace at with @)
Linux NTFS maintainer / IRC: #ntfs on irc.openprojects.net
WWW: http://linux-ntfs.sf.net/, http://www-stu.christs.cam.ac.uk/~aia21/

===================================================================

This will update the following files:

kernel/ksyms.c | 2 --
1 files changed, 2 deletions(-)

through these ChangeSets:

<[email protected]> (02/08/23 1.588)
Remove duplicate & bogus kmap_prot and kmap_pte exports.
These are arch specific and only four architectures implement them. So
on all other orchitectures with highmem enabled compilation would fail with
these exports in ksyms.c... The architectures which need them already
export them via their arch-ksyms files.


diff -Nru a/kernel/ksyms.c b/kernel/ksyms.c
--- a/kernel/ksyms.c Fri Aug 23 00:39:13 2002
+++ b/kernel/ksyms.c Fri Aug 23 00:39:13 2002
@@ -123,8 +123,6 @@
EXPORT_SYMBOL(kunmap_high);
EXPORT_SYMBOL(highmem_start_page);
EXPORT_SYMBOL(create_bounce);
-EXPORT_SYMBOL(kmap_prot);
-EXPORT_SYMBOL(kmap_pte);
#endif

/* filesystem internal functions */

===================================================================

This BitKeeper patch contains the following changesets:
+
## Wrapped with gzip_uu ##


begin 664 bkpatch2875
M'XL(`"%V93T``^U576O;,!1]CG[%A<)>2AQ)=AP[D)&M'1MLL)*NST.5KVL1
MV3*2G#3@'S_%">V:=925/>QA_L#VU='AW(^#S^#&H9V/A!*<D3/X9)R?CZ1H
MO+B-&O0AM#(FA":=LQ-GY:065J(V8QXEXW4MVE+=DX"Z$EY6L$'KYB,6Q0\1
MOVMQ/EI]^'CSY=V*D,4"+BK1W.$U>E@LB#=V(W3AEL)7VC21MZ)Q-7H125/W
M#]">4\K#.66SF$[3GJ4TF?62%8R)A&%!>9*E"3EJ6[:ZD^M=5"CGK0E,#4JO
M-N*4+V,YCWF:Q#WG.<W));!HFF5`^81F$QX#I?,XG2?TG+(YI3`4:?E8'#AG
M,*;D/?S=+"Z(A!769H-0=*U64GB$-W!K[CH'^Y)_;ZWQ()KB^!66\;XUUKLH
M;/U6H4,0=G^'!K@6I2J5'/"FT3LH36>'->5#73J+#E3=:JRQ\>`KK".X-H'(
M-""T!A-"%LP3_%;Y"BIU5]58`S;B5F,!(==6:>%5V+@UG2Z@%$H/V,#F!UE'
MG:`:6+M=[2(91=%>\HF@;:6"]@8#[5Y1$&)1%+O`<V`X1#=*[%_4(9WQP`BE
MTA@*\1EX'.<9N7H<.#+^PX,0*BAY^T)_UV@;U)-C/C\W.8_S/CQIW,^*65QF
M0A;3,N/Y3/XR2\^R9)R')-)XVL<Y3=+!/D]Q+WOH->I():NE=CXJ\'E=C+,\
MF25YGP3_\,$X*3OU33S]K6\HC/E_W_RCOCG,VE<8V^UP!1]<G8S=*YQTR7@*
:_/%7(2N4:]?5"Y&GLIREC/P`F%1GGHP&````
`
end


2002-08-24 14:04:20

by Pawel Kot

[permalink] [raw]
Subject: Re: [BK-2.4 PATCH] Fix compile with highmem and highio

On Fri, 23 Aug 2002, Anton Altaparmakov wrote:

> Remove duplicate & bogus kmap_prot and kmap_pte exports.
> These are arch specific and only four architectures implement them. So
> on all other orchitectures with highmem enabled compilation would fail with
> these exports in ksyms.c...

No, only these 4 architectures allow to set HIGHMEM. So no failure here.

> The architectures which need them already export them via their arch-ksyms files.

No. They don't. At least in 2.4.20-pre4. I think they may be exported in
your tree, because of the ntfs backport patch.

pkot
--
mailto:[email protected] :: mailto:[email protected]
http://kt.linuxnews.pl/ :: Kernel Traffic po polsku

2002-08-24 15:07:26

by Anton Altaparmakov

[permalink] [raw]
Subject: Re: [BK-2.4 PATCH] Fix compile with highmem and highio

At 15:08 24/08/02, Pawel Kot wrote:
>On Fri, 23 Aug 2002, Anton Altaparmakov wrote:
>
> > Remove duplicate & bogus kmap_prot and kmap_pte exports.
> > These are arch specific and only four architectures implement them. So
> > on all other orchitectures with highmem enabled compilation would
> fail with
> > these exports in ksyms.c...
>
>No, only these 4 architectures allow to set HIGHMEM. So no failure here.
>
> > The architectures which need them already export them via their
> arch-ksyms files.
>
>No. They don't. At least in 2.4.20-pre4. I think they may be exported in
>your tree, because of the ntfs backport patch.

Oops. You are right. I need to reclone a clean 2.4 tree. Mine has somehow
managed to gain a few "extra" changesets. Ahem.

Sorry for the noise.

Anton


--
"I've not lost my mind. It's backed up on tape somewhere." - Unknown
--
Anton Altaparmakov <aia21 at cantab.net> (replace at with @)
Linux NTFS Maintainer / IRC: #ntfs on irc.openprojects.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/