2002-09-28 20:50:41

by David Mosberger

Subject: [patch] avoid reference to struct page before it's declared

GCC currently warns when page-flags.h gets included before struct page
is declared. Patch below fixes this.

--david
--
Interested in learning more about IA-64 Linux? Try http://www.lia64.org/book/

===== include/linux/page-flags.h 1.21 vs edited =====
--- 1.21/include/linux/page-flags.h Fri Sep 27 15:52:04 2002
+++ edited/include/linux/page-flags.h Sat Sep 28 12:50:48 2002
@@ -211,6 +211,8 @@
extern struct address_space swapper_space;
#define PageSwapCache(page) ((page)->mapping == &swapper_space)

+struct page; /* forward declaration */
+
int test_clear_page_dirty(struct page *page);

static inline void clear_page_dirty(struct page *page)

2002-09-30 14:42:41

by Daniel Phillips

Subject: Re: [patch] avoid reference to struct page before it's declared

On Saturday 28 September 2002 22:56, David Mosberger wrote:
> GCC currently warns when page-flags.h gets included before struct page
> is declared. Patch below fixes this.

A better way is to compile struct page and related structure definitions
right at the beginning of mm.h, before declaring any helper functions. I
posted a patch to do this, earlier in 2.4, and should bring it forward.

--
Daniel