2003-08-11 16:04:03

by Dave Jones

Subject: [PATCH] missing copy_from_user check in comx_proto_lapb driver

diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/net/wan/comx-proto-lapb.c linux-2.5/drivers/net/wan/comx-proto-lapb.c
--- bk-linus/drivers/net/wan/comx-proto-lapb.c 2003-05-20 18:41:21.000000000 +0100
+++ linux-2.5/drivers/net/wan/comx-proto-lapb.c 2003-07-13 06:04:34.000000000 +0100
@@ -232,7 +232,10 @@ static int comxlapb_write_proc(struct fi
return -ENOMEM;
}

- copy_from_user(page, buffer, count);
+ if (copy_from_user(page, buffer, count)) {
+ free_page((unsigned long)page);
+ return -EFAULT;
+ }
if (*(page + count - 1) == '\n') {
*(page + count - 1) = 0;
}