2004-09-01 23:21:54

by maximilian attems

[permalink] [raw]
Subject: [patch 09/14] radio/radio-sf16fmi: replace schedule_timeout() with msleep()







I would appreciate any comments from the janitor@sternweltens list.

Thanks,
Nish



Description: Replaced schedule_timeout() with msleep() to guarantee the
task delays the desired time.

Signed-off-by: Nishanth Aravamudan <[email protected]>
Signed-off-by: Maximilian Attems <[email protected]>



---

linux-2.6.9-rc1-bk7-max/drivers/media/radio/radio-sf16fmi.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)

diff -puN drivers/media/radio/radio-sf16fmi.c~msleep-drivers_media_radio-sf16fmi drivers/media/radio/radio-sf16fmi.c
--- linux-2.6.9-rc1-bk7/drivers/media/radio/radio-sf16fmi.c~msleep-drivers_media_radio-sf16fmi 2004-09-01 19:35:13.000000000 +0200
+++ linux-2.6.9-rc1-bk7-max/drivers/media/radio/radio-sf16fmi.c 2004-09-01 19:35:13.000000000 +0200
@@ -89,8 +89,7 @@ static inline int fmi_setfreq(struct fmi

outbits(16, RSF16_ENCODE(freq), myport);
outbits(8, 0xC0, myport);
- current->state = TASK_UNINTERRUPTIBLE;
- schedule_timeout(HZ/7);
+ msleep(143); /* was schedule_timeout(HZ/7) */
up(&lock);
if (dev->curvol) fmi_unmute(myport);
return 0;
@@ -107,8 +106,7 @@ static inline int fmi_getsigstr(struct f
val = dev->curvol ? 0x08 : 0x00; /* unmute/mute */
outb(val, myport);
outb(val | 0x10, myport);
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(HZ/7);
+ msleep(143); /* was schedule_timeout(HZ/7) */
res = (int)inb(myport+1);
outb(val, myport);


_