2004-09-24 02:09:55

by maximilian attems

[permalink] [raw]
Subject: [patch 14/26] char/moxa: replace schedule_timeout() with msleep_interruptible()




Any comments would be appreciated.

Description: Use msleep_interruptible() instead of schedule_timeout() to
guarantee the task delays as expected.

Signed-off-by: Nishanth Aravamudan <[email protected]>

Signed-off-by: Maximilian Attems <[email protected]>
---

linux-2.6.9-rc2-bk7-max/drivers/char/moxa.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)

diff -puN drivers/char/moxa.c~msleep_interruptible-drivers_char_moxa drivers/char/moxa.c
--- linux-2.6.9-rc2-bk7/drivers/char/moxa.c~msleep_interruptible-drivers_char_moxa 2004-09-21 21:08:13.000000000 +0200
+++ linux-2.6.9-rc2-bk7-max/drivers/char/moxa.c 2004-09-21 21:08:13.000000000 +0200
@@ -625,8 +625,7 @@ static void moxa_close(struct tty_struct
ch->tty = NULL;
if (ch->blocked_open) {
if (ch->close_delay) {
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(ch->close_delay);
+ msleep_interruptible(jiffies_to_msecs(ch->close_delay));
}
wake_up_interruptible(&ch->open_wait);
}
_