2004-09-24 03:39:54

by maximilian attems

[permalink] [raw]
Subject: [patch 25/26] char/tpqic02: replace schedule_timeout() with msleep_interruptible()




Any comments would be appreciated.

Description: Use msleep_interruptible() instead of schedule_timeout() to
guarantee the task delays as expected.

Signed-off-by: Nishanth Aravamudan <[email protected]>

Signed-off-by: Maximilian Attems <[email protected]>
---

linux-2.6.9-rc2-bk7-max/drivers/char/tpqic02.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)

diff -puN drivers/char/tpqic02.c~msleep_interruptible-drivers_char_tpqic02 drivers/char/tpqic02.c
--- linux-2.6.9-rc2-bk7/drivers/char/tpqic02.c~msleep_interruptible-drivers_char_tpqic02 2004-09-21 21:08:26.000000000 +0200
+++ linux-2.6.9-rc2-bk7-max/drivers/char/tpqic02.c 2004-09-21 21:08:26.000000000 +0200
@@ -554,10 +554,9 @@ static int wait_for_ready(time_t timeout
/* not ready and no exception && timeout not expired yet */
while (((stat = inb_p(QIC02_STAT_PORT) & QIC02_STAT_MASK) == QIC02_STAT_MASK) && time_before(jiffies, spin_t)) {
/* be `nice` to other processes on long operations... */
- current->state = TASK_INTERRUPTIBLE;
/* nap 0.30 sec between checks, */
/* but could be woken up earlier by signals... */
- schedule_timeout(3 * HZ / 10);
+ msleep_interruptible(300);
}

/* don't use jiffies for this test because it may have changed by now */
_