2004-09-23 20:33:05

by maximilian attems

[permalink] [raw]
Subject: [patch 26/26] char/zftape-buffers: replace schedule_timeout() with msleep_interruptible()




Any comments would be appreciated. There actually won't be a PATCH
33/33, because I dropped one that even I wouldn't approve :)

Description: Use msleep_interruptible() instead of schedule_timeout() to
guarantee the task delays as expected.

Signed-off-by: Nishanth Aravamudan <[email protected]>

---

linux-2.6.9-rc2-bk7-max/drivers/char/ftape/zftape/zftape-buffers.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff -puN drivers/char/ftape/zftape/zftape-buffers.c~msleep_interruptible-drivers_char_zftape-buffers drivers/char/ftape/zftape/zftape-buffers.c
--- linux-2.6.9-rc2-bk7/drivers/char/ftape/zftape/zftape-buffers.c~msleep_interruptible-drivers_char_zftape-buffers 2004-09-21 22:54:49.000000000 +0200
+++ linux-2.6.9-rc2-bk7-max/drivers/char/ftape/zftape/zftape-buffers.c 2004-09-21 22:55:52.000000000 +0200
@@ -27,6 +27,7 @@
#include <linux/errno.h>
#include <linux/mm.h>
#include <linux/slab.h>
+#include <linux/delay.h>

#include <linux/zftape.h>

@@ -119,8 +120,7 @@ void *zft_kmalloc(size_t size)
void *new;

while ((new = kmalloc(size, GFP_KERNEL)) == NULL) {
- current->state = TASK_INTERRUPTIBLE;
- schedule_timeout(HZ/10);
+ msleep_interruptible(100);
}
memset(new, 0, size);
used_memory += size;
_