2004-09-23 20:55:26

by maximilian attems

Subject: [patch 4/4] mmc: replace schedule_timeout() with msleep_interruptible()

Any comments would be appreciated.

Description: Use msleep_interruptible() instead of schedule_timeout()
to guarantee the task delays as expected.

Signed-off-by: Nishanth Aravamudan <[email protected]>

Signed-off-by: Maximilian Attems <[email protected]>
---

linux-2.6.9-rc2-bk7-max/drivers/mmc/mmc.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)

diff -puN drivers/mmc/mmc.c~msleep_interruptible-drivers_mmc_mmc drivers/mmc/mmc.c
--- linux-2.6.9-rc2-bk7/drivers/mmc/mmc.c~msleep_interruptible-drivers_mmc_mmc 2004-09-21 21:17:16.000000000 +0200
+++ linux-2.6.9-rc2-bk7-max/drivers/mmc/mmc.c 2004-09-21 21:17:16.000000000 +0200
@@ -270,8 +270,7 @@ static inline void mmc_delay(unsigned in
yield();
mdelay(ms);
} else {
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(ms * HZ / 1000);
+ msleep_interruptible (ms);
}
}

_

2004-09-29 13:58:34

by Russell King

Subject: Re: [patch 4/4] mmc: replace schedule_timeout() with msleep_interruptible()

On Thu, Sep 23, 2004 at 10:49:10PM +0200, [email protected] wrote:
> Description: Use msleep_interruptible() instead of schedule_timeout()
> to guarantee the task delays as expected.

Applied, thanks.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core