I would appreciate any comments from the janitor@sternweltens list. This is one (of
many) cases where I made a decision about replacing
set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(some_time);
with
msleep(jiffies_to_msecs(some_time));
msleep() is not exactly the same as the previous code, but I only did
this replacement where I thought long delays were *desired*. If this is
not the case here, then just disregard this patch.
Thanks,
Nish
Description: Use msleep() instead of schedule_timeout() to guarantee
desired timeout.
Signed-off-by: Nishanth Aravamudan <[email protected]>
Signed-off-by: Maximilian Attems <[email protected]>
---
linux-2.6.10-rc2-bk4-max/drivers/ieee1394/sbp2.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)
diff -puN drivers/ieee1394/sbp2.c~msleep-drivers_ieee1394_sbp2 drivers/ieee1394/sbp2.c
--- linux-2.6.10-rc2-bk4/drivers/ieee1394/sbp2.c~msleep-drivers_ieee1394_sbp2 2004-11-19 17:15:14.000000000 +0100
+++ linux-2.6.10-rc2-bk4-max/drivers/ieee1394/sbp2.c 2004-11-19 17:15:14.000000000 +0100
@@ -902,8 +902,7 @@ alloc_fail:
* connected to the sbp2 device being removed. That host would
* have a certain amount of time to relogin before the sbp2 device
* allows someone else to login instead. One second makes sense. */
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(HZ);
+ msleep(1000);
/*
* Login to the sbp-2 device
_