Hi Andrew!
I should have known that bragging about the stability of FUSE will get
me into trouble.
This patch fixes a use after free bug, which could in theory cause
memory corruption. It was actually found with DEBUG_PAGEALLOC by
Magnus Johansson.
Please apply.
Thanks,
Miklos
Signed-off-by: Miklos Szeredi <[email protected]>
diff -rup linux-2.6.11-mm1/fs/fuse/dev.c linux-fuse/fs/fuse/dev.c
--- linux-2.6.11-mm1/fs/fuse/dev.c 2005-03-04 23:26:59.000000000 +0100
+++ linux-fuse/fs/fuse/dev.c 2005-03-04 23:32:36.000000000 +0100
@@ -121,12 +121,11 @@ struct fuse_req *fuse_get_request_nonint
static void fuse_putback_request(struct fuse_conn *fc, struct fuse_req *req)
{
- if (!req->preallocated)
- fuse_request_free(req);
-
spin_lock(&fuse_lock);
if (req->preallocated)
list_add(&req->list, &fc->unused_list);
+ else
+ fuse_request_free(req);
if (fc->outstanding_debt)
fc->outstanding_debt--;