2005-03-19 13:29:25

by Domen Puncer

Subject: [patch 1/4] crypto/sha256.c: fix sparse warnings

Signed-off-by: Domen Puncer <[email protected]>
---


kj-domen/crypto/sha256.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN crypto/sha256.c~sparse-crypto_sha256 crypto/sha256.c
--- kj/crypto/sha256.c~sparse-crypto_sha256 2005-03-18 20:05:34.000000000 +0100
+++ kj-domen/crypto/sha256.c 2005-03-18 20:05:34.000000000 +0100
@@ -58,7 +58,7 @@ static inline u32 Maj(u32 x, u32 y, u32

static inline void LOAD_OP(int I, u32 *W, const u8 *input)
{
- W[I] = __be32_to_cpu( ((u32*)(input))[I] );
+ W[I] = __be32_to_cpu( ((__be32*)(input))[I] );
}

static inline void BLEND_OP(int I, u32 *W)
_

2005-03-20 07:33:58

by Herbert Xu

Subject: Re: [patch 1/4] crypto/sha256.c: fix sparse warnings

[email protected] wrote:
>
> diff -puN crypto/sha256.c~sparse-crypto_sha256 crypto/sha256.c
> --- kj/crypto/sha256.c~sparse-crypto_sha256 2005-03-18 20:05:34.000000000 +0100
> +++ kj-domen/crypto/sha256.c 2005-03-18 20:05:34.000000000 +0100
> @@ -58,7 +58,7 @@ static inline u32 Maj(u32 x, u32 y, u32
>
> static inline void LOAD_OP(int I, u32 *W, const u8 *input)
> {
> - W[I] = __be32_to_cpu( ((u32*)(input))[I] );
> + W[I] = __be32_to_cpu( ((__be32*)(input))[I] );

I don't get any warnings here (sparse version dated 12/03/2005).
What warnings are you getting exactly?

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2005-03-20 08:11:21

by Alexey Dobriyan

Subject: Re: [patch 1/4] crypto/sha256.c: fix sparse warnings

On Sunday 20 March 2005 10:32, Herbert Xu wrote:
> [email protected] wrote:
> > +++ kj-domen/crypto/sha256.c

> > static inline void LOAD_OP(int I, u32 *W, const u8 *input)
> > {
> > - W[I] = __be32_to_cpu( ((u32*)(input))[I] );
> > + W[I] = __be32_to_cpu( ((__be32*)(input))[I] );
>
> I don't get any warnings here (sparse version dated 12/03/2005).
> What warnings are you getting exactly?

crypto/sha256.c:61:9: warning: cast to restricted type

Use CHECK="sparse -Wbitwise" to see it.

Alexey

2005-03-20 09:40:31

by Herbert Xu

Subject: Re: [patch 1/4] crypto/sha256.c: fix sparse warnings

Alexey Dobriyan <[email protected]> wrote:
>
> crypto/sha256.c:61:9: warning: cast to restricted type
>
> Use CHECK="sparse -Wbitwise" to see it.

Thanks. I've applied all four patches to crypto. I changed patch 4/4
slightly so that it reads

+#define u32_in(x) le32_to_cpu(*(const __le32 *)(x))

instead of le32_to_cpup(...) for the sake of minimising the changes.

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2005-03-20 11:23:02

by Domen Puncer

Subject: Re: [patch 1/4 with proper signed-off] crypto/sha256.c: fix sparse warnings

Signed-off-by: Alexey Dobriyan <[email protected]>
Signed-off-by: Domen Puncer <[email protected]>
---


kj-domen/crypto/sha256.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN crypto/sha256.c~sparse-crypto_sha256 crypto/sha256.c
--- kj/crypto/sha256.c~sparse-crypto_sha256 2005-03-20 12:11:33.000000000 +0100
+++ kj-domen/crypto/sha256.c 2005-03-20 12:11:33.000000000 +0100
@@ -58,7 +58,7 @@ static inline u32 Maj(u32 x, u32 y, u32

static inline void LOAD_OP(int I, u32 *W, const u8 *input)
{
- W[I] = __be32_to_cpu( ((u32*)(input))[I] );
+ W[I] = __be32_to_cpu( ((__be32*)(input))[I] );
}

static inline void BLEND_OP(int I, u32 *W)
_