2005-04-23 22:23:45

by Adrian Bunk

[permalink] [raw]
Subject: [2.6 patch] drivers/scsi/FlashPoint.c: cleanups

This patch contains cleanups including the following:
- remove #ifdef'ed code for other OS's
- remove other unused code
- make needlessly global code static

Signed-off-by: Adrian Bunk <[email protected]>

---

Due to it's size, the patch is attached gzip'ed.

drivers/scsi/FlashPoint.c | 5872 ++++++--------------------------------
1 files changed, 973 insertions(+), 4899 deletions(-)


Attachments:
(No filename) (387.00 B)
patch-cleanup-FlashPoint.gz (46.20 kB)
Download all attachments

2005-04-24 07:26:19

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [2.6 patch] drivers/scsi/FlashPoint.c: cleanups

On Sun, Apr 24, 2005 at 12:17:12AM +0200, Adrian Bunk wrote:
> This patch contains cleanups including the following:
> - remove #ifdef'ed code for other OS's
> - remove other unused code
> - make needlessly global code static

I'd rather not touch this file currently. It's glued toghether from
lots of separate files in the original code. Before doing cleanups
I'd rather split it into all these files first as the file is a huge
mess as-is.

2005-04-25 09:34:54

by Alexey Dobriyan

[permalink] [raw]
Subject: Re: [2.6 patch] drivers/scsi/FlashPoint.c: cleanups

> This patch contains cleanups including the following:
> - remove #ifdef'ed code for other OS's
> - remove other unused code
> - make needlessly global code static

FYI, (1) and part of your (2) are already sitting in -kj (splitted).

http://coderock.org/kj/2.6.12-rc3-kj/split/defines-drivers_scsi_FlashPoint.patch
http://coderock.org/kj/2.6.12-rc3-kj/split/comments-drivers_scsi_FlashPoint

And I hope cleaning FlashPoint mess will be splitted.