2006-02-08 03:18:43

by Al Viro

Subject: [PATCH 04/29] missing includes in drivers/net/mv643xx_eth.c

Date: 1137630954 -0500

Signed-off-by: Al Viro <[email protected]>

---

drivers/net/mv643xx_eth.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

b6298c22c5e9f698812e2520003ee178aad50c10
diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
index 7ef4b04..c0998ef 100644
--- a/drivers/net/mv643xx_eth.c
+++ b/drivers/net/mv643xx_eth.c
@@ -32,6 +32,8 @@
*/
#include <linux/init.h>
#include <linux/dma-mapping.h>
+#include <linux/in.h>
+#include <linux/ip.h>
#include <linux/tcp.h>
#include <linux/udp.h>
#include <linux/etherdevice.h>
--
0.99.9.GIT

2006-02-08 03:53:49

by Jeff Garzik

Subject: Re: [PATCH 04/29] missing includes in drivers/net/mv643xx_eth.c

Al Viro wrote:
> Date: 1137630954 -0500
>
> Signed-off-by: Al Viro <[email protected]>

ACK

2006-02-08 12:28:23

by Dale Farnsworth

Subject: [PATCH] mv643xx_eth: remove repeated includes of linux/in.h and linux/ip.h

From: Dale Farnsworth <[email protected]>

Signed-off-by: Dale Farnsworth <[email protected]>

---

These includes were added twice:
in commit 78a5e534758349fd3effc90ce1152b55368f52ee by Olaf Hering and
in commit b6298c22c5e9f698812e2520003ee178aad50c10 by Al Viro.
This patch reverts 78a5e534758349fd3effc90ce1152b55368f52ee.

They probably should have been included before linux/tcp.h in
the first place.

drivers/net/mv643xx_eth.c | 2 --
1 file changed, 2 deletions(-)

Index: linux-2.6-mv643xx_enet/drivers/net/mv643xx_eth.c
===================================================================
--- linux-2.6-mv643xx_enet.orig/drivers/net/mv643xx_eth.c
+++ linux-2.6-mv643xx_enet/drivers/net/mv643xx_eth.c
@@ -37,8 +37,6 @@
#include <linux/tcp.h>
#include <linux/udp.h>
#include <linux/etherdevice.h>
-#include <linux/in.h>
-#include <linux/ip.h>

#include <linux/bitops.h>
#include <linux/delay.h>