2006-03-07 19:48:24

by Eric Sesterhenn

Subject: [Patch] Dead code in drivers/isdn/avm/avmcard.h

hi,

this fixes coverity id #2. the if (i==0) is pretty useless,
since we assing i=0, just the line before.
Just compile tested.

Signed-off-by: Eric Sesterhenn <[email protected]>

--- linux-2.6.16-rc5-mm1/drivers/isdn/hardware/avm/avmcard.h.orig 2006-03-07 20:44:33.000000000 +0100
+++ linux-2.6.16-rc5-mm1/drivers/isdn/hardware/avm/avmcard.h 2006-03-07 20:44:38.000000000 +0100
@@ -437,8 +437,7 @@ static inline unsigned int t1_get_slice(
#endif
dp += i;
i = 0;
- if (i == 0)
- break;
+ break;
/* fall through */
default:
*dp++ = b1_get_byte(base);

2006-03-07 20:38:06

by Eric Sesterhenn

Subject: Re: [Patch] Dead code in drivers/isdn/avm/avmcard.h

On Tue, 2006-03-07 at 20:30 +0000, Thorsten Kranzkowski wrote:
> On Tue, Mar 07, 2006 at 08:48:20PM +0100, Eric Sesterhenn wrote:
> > hi,
> >
> > this fixes coverity id #2. the if (i==0) is pretty useless,
> > since we assing i=0, just the line before.
> > Just compile tested.
>
> Iff this is the right fix the comment should be removed as well, no?

updated patch below.

Signed-off-by: Eric Sesterhenn

--- linux-2.6.16-rc5-mm1/drivers/isdn/hardware/avm/avmcard.h.orig 2006-03-07 20:44:33.000000000 +0100
+++ linux-2.6.16-rc5-mm1/drivers/isdn/hardware/avm/avmcard.h 2006-03-07 21:34:31.000000000 +0100
@@ -437,9 +437,7 @@ static inline unsigned int t1_get_slice(
#endif
dp += i;
i = 0;
- if (i == 0)
- break;
- /* fall through */
+ break;
default:
*dp++ = b1_get_byte(base);
i--;

2006-03-07 21:27:10

by Olaf Titz

Subject: Re: [Patch] Dead code in drivers/isdn/avm/avmcard.h

> i = 0;
> - if (i == 0)
> - break;
> + break;
> /* fall through */
> default:

This leaves the "fall through" comment as bogus, remove that too.

Olaf