2006-08-16 17:33:12

by Vincent Perrier

[permalink] [raw]
Subject: New version of ClownToolKit

Hello,

The kernel module of the last version of the ClownToolKit has been
completly rewriten. It is now readable.
This kernel module permits the display of real-time plots for
bandwidth of tcp/udp connexions and for qdiscs monitoring.
It could be a usefull tool: http://clowncode.net
Regards to you all
Vincent Perrier.


2006-08-16 18:48:52

by Sam Ravnborg

[permalink] [raw]
Subject: Re: New version of ClownToolKit

On Wed, Aug 16, 2006 at 07:33:08PM +0200, clowncoder wrote:
> Hello,
>
> The kernel module of the last version of the ClownToolKit has been
> completly rewriten. It is now readable.
> This kernel module permits the display of real-time plots for
> bandwidth of tcp/udp connexions and for qdiscs monitoring.
> It could be a usefull tool: http://clowncode.net

A small nitpick about the way ou build the ekrnel module:

In mk_and_insmod you can replace:
make -C /usr/src/linux SUBDIRS=$PWD modules
with
LIBDIR=/lib/modules/`uname -r`
make -C $LIBDIR/source O=$LIBDIR/build SUBDIRS=`pwd` modules

For a normal kernel installation this will do the right thing.
source points to the kernel source and build point to the output
directory (they are often equal but not always).

$PWD is supplied by the shell, so it is better to use `pwd`.

Sam

2006-08-16 23:18:28

by Bodo Eggert

[permalink] [raw]
Subject: Re: New version of ClownToolKit

Sam Ravnborg <[email protected]> wrote:

> A small nitpick about the way ou build the ekrnel module:
>
> In mk_and_insmod you can replace:
> make -C /usr/src/linux SUBDIRS=$PWD modules
> with
> LIBDIR=/lib/modules/`uname -r`
> make -C $LIBDIR/source O=$LIBDIR/build SUBDIRS=`pwd` modules
>
> For a normal kernel installation this will do the right thing.
> source points to the kernel source and build point to the output
> directory (they are often equal but not always).

Please don't tell module authors to unconditionally use `uname -r`.
I frequently build kernels for differentd hosts, and if I don't, I'll
certainly compile the needed modules before installing the kernel.
Therefore /lib/modules/`uname -r` is most certainly the completely
wrong place to look for the kernel source.
--
Ich danke GMX daf?r, die Verwendung meiner Adressen mittels per SPF
verbreiteten L?gen zu sabotieren.

http://david.woodhou.se/why-not-spf.html

2006-08-17 04:42:29

by Sam Ravnborg

[permalink] [raw]
Subject: Re: New version of ClownToolKit

On Thu, Aug 17, 2006 at 01:15:43AM +0200, Bodo Eggert wrote:
> Sam Ravnborg <[email protected]> wrote:
>
> > A small nitpick about the way ou build the ekrnel module:
> >
> > In mk_and_insmod you can replace:
> > make -C /usr/src/linux SUBDIRS=$PWD modules
> > with
> > LIBDIR=/lib/modules/`uname -r`
> > make -C $LIBDIR/source O=$LIBDIR/build SUBDIRS=`pwd` modules
> >
> > For a normal kernel installation this will do the right thing.
> > source points to the kernel source and build point to the output
> > directory (they are often equal but not always).
>
> Please don't tell module authors to unconditionally use `uname -r`.
> I frequently build kernels for differentd hosts, and if I don't, I'll
> certainly compile the needed modules before installing the kernel.
> Therefore /lib/modules/`uname -r` is most certainly the completely
> wrong place to look for the kernel source.
/lib/modules/`uname -r` is the general solution that works for most
people and should be at least default. It is certainly better than
/usr/src/linux.
But yes they better make it override able.

Sam

2006-08-17 07:46:12

by Jan Engelhardt

[permalink] [raw]
Subject: Re: New version of ClownToolKit

>> The kernel module of the last version of the ClownToolKit has been
>> completly rewriten. It is now readable.
>> This kernel module permits the display of real-time plots for
>> bandwidth of tcp/udp connexions and for qdiscs monitoring.
>> It could be a usefull tool: http://clowncode.net
>
>A small nitpick about the way ou build the ekrnel module:
>
>In mk_and_insmod you can replace:
>make -C /usr/src/linux SUBDIRS=$PWD modules
>with
>LIBDIR=/lib/modules/`uname -r`
>make -C $LIBDIR/source O=$LIBDIR/build SUBDIRS=`pwd` modules

Might like to replace with
make -C $LIBDIR/build M=`pwd` modules

>$PWD is supplied by the shell, so it is better to use `pwd`.

Does not harm really.


Jan Engelhardt
--

2006-08-17 07:49:32

by Jan Engelhardt

[permalink] [raw]
Subject: Re: New version of ClownToolKit

>> > LIBDIR=/lib/modules/`uname -r`
>> > make -C $LIBDIR/source O=$LIBDIR/build SUBDIRS=`pwd` modules
>> >
>> > For a normal kernel installation this will do the right thing.
>> > source points to the kernel source and build point to the output
>> > directory (they are often equal but not always).
>>
>> Please don't tell module authors to unconditionally use `uname -r`.
>> I frequently build kernels for differentd hosts, and if I don't, I'll
>> certainly compile the needed modules before installing the kernel.
>> Therefore /lib/modules/`uname -r` is most certainly the completely
>> wrong place to look for the kernel source.
>
>/lib/modules/`uname -r` is the general solution that works for most
>people and should be at least default. It is certainly better than
>/usr/src/linux.
>But yes they better make it override able.

In some outoftree modules of mine, the Makefile reads like this

MODULES_DIR := /lib/modules/$(shell uname -r)
KSRC_DIR := ${MODULES_DIR}/source
KOBJ_DIR := ${MODULES_DIR}/build

all: modules
modules:
make -C "${KOBJ_DIR}" M="$$PWD";

and one can easily override it by calling `make MODULES_DIR=/foo/bar`
(instead of just `make`).


Jan Engelhardt
--

2006-08-17 17:04:54

by Vincent Perrier

[permalink] [raw]
Subject: Re: New version of ClownToolKit

Le jeudi 17 août 2006 à 09:47 +0200, Jan Engelhardt a écrit :
> >> > LIBDIR=/lib/modules/`uname -r`
> >> > make -C $LIBDIR/source O=$LIBDIR/build SUBDIRS=`pwd` modules
> >> >
> >> > For a normal kernel installation this will do the right thing.
> >> > source points to the kernel source and build point to the output
> >> > directory (they are often equal but not always).
> >>
> >> Please don't tell module authors to unconditionally use `uname -r`.
> >> I frequently build kernels for differentd hosts, and if I don't, I'll
> >> certainly compile the needed modules before installing the kernel.
> >> Therefore /lib/modules/`uname -r` is most certainly the completely
> >> wrong place to look for the kernel source.
> >
> >/lib/modules/`uname -r` is the general solution that works for most
> >people and should be at least default. It is certainly better than
> >/usr/src/linux.
> >But yes they better make it override able.
>
> In some outoftree modules of mine, the Makefile reads like this
>
> MODULES_DIR := /lib/modules/$(shell uname -r)
> KSRC_DIR := ${MODULES_DIR}/source
> KOBJ_DIR := ${MODULES_DIR}/build
>
> all: modules
> modules:
> make -C "${KOBJ_DIR}" M="$$PWD";
>
> and one can easily override it by calling `make MODULES_DIR=/foo/bar`
> (instead of just `make`).
>
>
> Jan Engelhardt

Thank you all for all those tips, I will use this last one.

Vincent Perrier