2006-10-05 15:42:17

by Joerg Roedel

[permalink] [raw]
Subject: [PATCH][RFC] net/ipv6: seperate sit driver to extra module

Is there a reason why the tunnel driver for IPv6-in-IPv4 is currently
compiled into the ipv6 module? This driver is only needed in gateways
between different IPv6 networks. On all other hosts with ipv6 enabled it
is not required. To have this driver in a seperate module will save
memory on those machines.
I appended a small and trival patch to 2.6.18 which does exactly this.

Joerg


Attachments:
(No filename) (385.00 B)
patch_sit_as_module (2.85 kB)
Download all attachments

2006-10-05 15:49:41

by James Morris

[permalink] [raw]
Subject: Re: [PATCH][RFC] net/ipv6: seperate sit driver to extra module

On Thu, 5 Oct 2006, Joerg Roedel wrote:

> Is there a reason why the tunnel driver for IPv6-in-IPv4 is currently
> compiled into the ipv6 module? This driver is only needed in gateways
> between different IPv6 networks. On all other hosts with ipv6 enabled it
> is not required. To have this driver in a seperate module will save
> memory on those machines.
> I appended a small and trival patch to 2.6.18 which does exactly this.

Looks ok to me, although given that users used to get this by default when
selecting IPv6, perhaps the default in Kconfig should be y.



- James
--
James Morris
<[email protected]>

2006-10-05 15:59:57

by Joerg Roedel

[permalink] [raw]
Subject: Re: [PATCH][RFC] net/ipv6: seperate sit driver to extra module

On Thu, Oct 05, 2006 at 11:49:38AM -0400, James Morris wrote:
> On Thu, 5 Oct 2006, Joerg Roedel wrote:
>
> > Is there a reason why the tunnel driver for IPv6-in-IPv4 is currently
> > compiled into the ipv6 module? This driver is only needed in gateways
> > between different IPv6 networks. On all other hosts with ipv6 enabled it
> > is not required. To have this driver in a seperate module will save
> > memory on those machines.
> > I appended a small and trival patch to 2.6.18 which does exactly this.
>
> Looks ok to me, although given that users used to get this by default when
> selecting IPv6, perhaps the default in Kconfig should be y.

Ok, a good point to write y there. I change this. I wrote n there
because of the "If unsure, say N" sentence in the description.

Joerg

2006-10-05 17:24:13

by YOSHIFUJI Hideaki

[permalink] [raw]
Subject: Re: [PATCH][RFC] net/ipv6: seperate sit driver to extra module

In article <[email protected]> (at Thu, 5 Oct 2006 11:49:38 -0400 (EDT)), James Morris <[email protected]> says:

> On Thu, 5 Oct 2006, Joerg Roedel wrote:
>
> > Is there a reason why the tunnel driver for IPv6-in-IPv4 is currently
> > compiled into the ipv6 module? This driver is only needed in gateways
> > between different IPv6 networks. On all other hosts with ipv6 enabled it
> > is not required. To have this driver in a seperate module will save
> > memory on those machines.
> > I appended a small and trival patch to 2.6.18 which does exactly this.
>
> Looks ok to me, although given that users used to get this by default when
> selecting IPv6, perhaps the default in Kconfig should be y.

Agreed. And, we could add #ifdef in addrconf.c.

--yoshfuji

2006-10-05 20:37:12

by Olaf Titz

[permalink] [raw]
Subject: Re: [PATCH][RFC] net/ipv6: seperate sit driver to extra module

> Looks ok to me, although given that users used to get this by default when
> selecting IPv6, perhaps the default in Kconfig should be y.

Yes, and the fact that the easiest way to get IPv6 connectivity [1] needs
this driver suggests defaulting to yes (and changing the "if unsure..."
wording) too.

Olaf

[1] see RFC 3056, RFC 3068; http://sites.inka.de/bigred/sw/6to4