2007-02-01 13:53:06

by Al Viro

Subject: [PATCH] ide section fixes

a) cleanup_module() should be __exit
b) externs should match reality

Signed-off-by: Al Viro <[email protected]>
---
drivers/ide/ide.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/ide/ide.c b/drivers/ide/ide.c
index 3b334af..6c9bd51 100644
--- a/drivers/ide/ide.c
+++ b/drivers/ide/ide.c
@@ -1781,9 +1781,9 @@ done:
return 1;
}

-extern void pnpide_init(void);
-extern void pnpide_exit(void);
-extern void h8300_ide_init(void);
+extern void __init pnpide_init(void);
+extern void __exit pnpide_exit(void);
+extern void __init h8300_ide_init(void);

/*
* probe_for_hwifs() finds/initializes "known" IDE interfaces
@@ -2088,7 +2088,7 @@ int __init init_module (void)
return ide_init();
}

-void cleanup_module (void)
+void __exit cleanup_module (void)
{
int index;

--
1.5.0-rc2.GIT

2007-02-06 22:48:53

by Bartlomiej Zolnierkiewicz

Subject: Re: [PATCH] ide section fixes

On 2/1/07, Al Viro <[email protected]> wrote:
>
> a) cleanup_module() should be __exit
> b) externs should match reality
>
> Signed-off-by: Al Viro <[email protected]>

applied, thanks

2007-02-07 01:06:10

by Bartlomiej Zolnierkiewicz

Subject: Re: [PATCH] ide section fixes

On 2/6/07, Bartlomiej Zolnierkiewicz <[email protected]> wrote:
> On 2/1/07, Al Viro <[email protected]> wrote:
> >
> > a) cleanup_module() should be __exit
> > b) externs should match reality
> >
> > Signed-off-by: Al Viro <[email protected]>
>
> applied, thanks

hmm, Linus has already applied, great :)