2007-05-02 06:34:47

by Herbert Xu

Subject: Re: [patch 31/32] xen: --- drivers/net/xen-netfront.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

Jeremy Fitzhardinge <[email protected]> wrote:
> ===================================================================
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -1213,10 +1213,10 @@ static int netif_poll(struct net_device

Any reason why xen-netfront isn't just in a single patch? It makes
it a bit hard to review having it scattered around like this.

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2007-05-02 06:47:42

by Chris Wright

Subject: Re: [patch 31/32] xen: --- drivers/net/xen-netfront.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

* Herbert Xu ([email protected]) wrote:
> Jeremy Fitzhardinge <[email protected]> wrote:
> > ===================================================================
> > --- a/drivers/net/xen-netfront.c
> > +++ b/drivers/net/xen-netfront.c
> > @@ -1213,10 +1213,10 @@ static int netif_poll(struct net_device
>
> Any reason why xen-netfront isn't just in a single patch? It makes
> it a bit hard to review having it scattered around like this.

It simply maps directly to the patch queue. We do go back and fold
things in and that should probably be done again, I agree.

thanks,
-chris

2007-05-02 06:49:07

by Jeremy Fitzhardinge

Subject: Re: [patch 31/32] xen: --- drivers/net/xen-netfront.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

Chris Wright wrote:
> It simply maps directly to the patch queue. We do go back and fold
> things in and that should probably be done again, I agree.
>

Yeah, I've folded them all up now. Tracking xen-unstable is going to be
tricker though.

J