2008-02-23 17:56:58

by Laura Garcia

Subject: [PATCH 1/2]via-rhine.c: Use-register-offset-definition-for-WOLcgClr

Use register offset definition for WOLcgClr. This patch does not
change the driver behaviour.

Signed-off-by: Laura Garcia Liebana <[email protected]>

modified: drivers/net/via-rhine.c
---
drivers/net/via-rhine.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/via-rhine.c b/drivers/net/via-rhine.c
index 7c851b1..8c9d6ae 100644
--- a/drivers/net/via-rhine.c
+++ b/drivers/net/via-rhine.c
@@ -1893,7 +1893,7 @@ static void rhine_shutdown (struct pci_dev *pdev)

/* Make sure we use pattern 0, 1 and not 4, 5 */
if (rp->quirks & rq6patterns)
- iowrite8(0x04, ioaddr + 0xA7);
+ iowrite8(0x04, ioaddr + WOLcgClr);

if (rp->wolopts & WAKE_MAGIC) {
iowrite8(WOLmagic, ioaddr + WOLcrSet);
--
1.5.3.8

2008-02-24 05:11:43

by Jeff Garzik

Subject: Re: [PATCH 1/2]via-rhine.c: Use-register-offset-definition-for-WOLcgClr

Laura Garcia wrote:
> Use register offset definition for WOLcgClr. This patch does not
> change the driver behaviour.
>
> Signed-off-by: Laura Garcia Liebana <[email protected]>
>
> modified: drivers/net/via-rhine.c
> ---
> drivers/net/via-rhine.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

applied, after making the following manual edits:

- removed "modified: ..." line, that is redundant to the diffstat, and
being before the "---" separator, it is included in the changelog by
automated tools

- removed all the silly dashes from the subject line. we want something
readable, not a filename.