2008-10-08 21:57:23

by Cliff Wickman

Subject: [PATCH] UV: cosmetic fix to interrupt handler definition

From: Cliff Wickman <[email protected]>

The UV Broadcast Assist Unit (BAU) interrupt handler is erroneously
declared with a hardcoded vector 220 (that was used during testing).
It should be declared with the vector that is reserved for it.

The interrupt handler does not use the 220 that is pushed onto its
stack, so this error had no runtime effect.

Diffed against 2.6.27-rc8

Signed-off-by: Cliff Wickman <[email protected]>
---
arch/x86/kernel/entry_64.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: 081002.linus/arch/x86/kernel/entry_64.S
===================================================================
--- 081002.linus.orig/arch/x86/kernel/entry_64.S
+++ 081002.linus/arch/x86/kernel/entry_64.S
@@ -878,7 +878,7 @@ ENTRY(apic_timer_interrupt)
END(apic_timer_interrupt)

ENTRY(uv_bau_message_intr1)
- apicinterrupt 220,uv_bau_message_interrupt
+ apicinterrupt UV_BAU_MESSAGE,uv_bau_message_interrupt
END(uv_bau_message_intr1)

ENTRY(error_interrupt)

2008-10-09 12:20:12

by Ingo Molnar

Subject: Re: [PATCH] UV: cosmetic fix to interrupt handler definition

* Cliff Wickman <[email protected]> wrote:

> From: Cliff Wickman <[email protected]>
>
> The UV Broadcast Assist Unit (BAU) interrupt handler is erroneously
> declared with a hardcoded vector 220 (that was used during testing).
> It should be declared with the vector that is reserved for it.
>
> The interrupt handler does not use the 220 that is pushed onto its
> stack, so this error had no runtime effect.
>
> Diffed against 2.6.27-rc8
>
> Signed-off-by: Cliff Wickman <[email protected]>

applied to tip/x86/uv, thanks Cliff!

Ingo