2008-11-22 17:39:55

by Al Viro

Subject: [PATCH 20/32] uninorth-agp section mess

'aperture' is declared devinitdata (the whole word of it) and
is used from ->fetch_size() which can, AFAICS, be used on
!HOTPLUG after init time.

Signed-off-by: Al Viro <[email protected]>
---
drivers/char/agp/uninorth-agp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/agp/uninorth-agp.c b/drivers/char/agp/uninorth-agp.c
--- a/drivers/char/agp/uninorth-agp.c
+++ b/drivers/char/agp/uninorth-agp.c
@@ -27,7 +27,7 @@
static int uninorth_rev;
static int is_u3;

-static char __devinitdata *aperture = NULL;
+static char *aperture = NULL;

static int uninorth_fetch_size(void)
{

2008-11-22 21:53:23

by Benjamin Herrenschmidt

Subject: Re: [PATCH 20/32] uninorth-agp section mess

On Sat, 2008-11-22 at 17:36 +0000, Al Viro wrote:
> 'aperture' is declared devinitdata (the whole word of it) and
> is used from ->fetch_size() which can, AFAICS, be used on
> !HOTPLUG after init time.
>
> Signed-off-by: Al Viro <[email protected]>

Acked-by: Benjamin Herrenschmidt <[email protected]>

> ---
> drivers/char/agp/uninorth-agp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/char/agp/uninorth-agp.c b/drivers/char/agp/uninorth-agp.c
> --- a/drivers/char/agp/uninorth-agp.c
> +++ b/drivers/char/agp/uninorth-agp.c
> @@ -27,7 +27,7 @@
> static int uninorth_rev;
> static int is_u3;
>
> -static char __devinitdata *aperture = NULL;
> +static char *aperture = NULL;
>
> static int uninorth_fetch_size(void)
> {
> _______________________________________________
> Linuxppc-dev mailing list
> [email protected]
> https://ozlabs.org/mailman/listinfo/linuxppc-dev