2012-10-01 04:33:00

by Tim Shepard

Subject: Re: CONFIG_EXPERT is a booby trap

Interestingly, of the 26 configs that use EXPERT in the default
clause, 15 of them are in drivers/hid (see below).

-Tim Shepard
[email protected]

- - - - - - - - - - - - - - - - - - - - - - - - - - - -

$ find . -type f -name Kconfig'*' -print | xargs fgrep default | grep EXPERT
./drivers/hid/Kconfig: default !EXPERT
./drivers/hid/Kconfig: default !EXPERT
./drivers/hid/Kconfig: default !EXPERT
./drivers/hid/Kconfig: default !EXPERT
./drivers/hid/Kconfig: default !EXPERT
./drivers/hid/Kconfig: default !EXPERT
./drivers/hid/Kconfig: default !EXPERT
./drivers/hid/Kconfig: default !EXPERT
./drivers/hid/Kconfig: default !EXPERT
./drivers/hid/Kconfig: default !EXPERT
./drivers/hid/Kconfig: default !EXPERT
./drivers/hid/Kconfig: default !EXPERT
./drivers/hid/Kconfig: default !EXPERT
./drivers/hid/Kconfig: default !EXPERT
./drivers/hid/Kconfig: default !EXPERT
./drivers/media/common/tuners/Kconfig: default y if !EXPERT
./drivers/media/common/tuners/Kconfig: default y if EXPERT
./drivers/media/dvb/frontends/Kconfig: default y if EXPERT
./drivers/media/video/Kconfig: default y if !EXPERT
./init/Kconfig: default !EXPERT
./lib/Kconfig.debug: default !EXPERT
./net/rfkill/Kconfig: default y if !EXPERT
./usr/Kconfig: default !EXPERT
./usr/Kconfig: default !EXPERT
./usr/Kconfig: default !EXPERT
./usr/Kconfig: default !EXPERT

2012-10-02 03:45:04

by David Rientjes

Subject: Re: CONFIG_EXPERT is a booby trap

On Mon, 1 Oct 2012, Tim Shepard wrote:

> Interestingly, of the 26 configs that use EXPERT in the default
> clause, 15 of them are in drivers/hid (see below).
>
> -Tim Shepard
> [email protected]
>
> - - - - - - - - - - - - - - - - - - - - - - - - - - - -
>
> $ find . -type f -name Kconfig'*' -print | xargs fgrep default | grep EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/media/common/tuners/Kconfig: default y if !EXPERT
> ./drivers/media/common/tuners/Kconfig: default y if EXPERT
> ./drivers/media/dvb/frontends/Kconfig: default y if EXPERT
> ./drivers/media/video/Kconfig: default y if !EXPERT
> ./init/Kconfig: default !EXPERT
> ./lib/Kconfig.debug: default !EXPERT
> ./net/rfkill/Kconfig: default y if !EXPERT
> ./usr/Kconfig: default !EXPERT
> ./usr/Kconfig: default !EXPERT
> ./usr/Kconfig: default !EXPERT
> ./usr/Kconfig: default !EXPERT

I don't think selecting CONFIG_EXPERT should change whether a config
option is enabled or disabled by default, I think it should only change
whether certain options are available for enabling or disabling. These do
need care when fixing, though, and in the above circumstances you may find
that s/EXPERT/EMBEDDED/ is the right change.