2013-03-22 13:42:27

by Ben Collins

[permalink] [raw]
Subject: [PATCH] phy: Add XGMII phy interface type

Used by systems based on certain Freescale SoCs (specifically the
Servergy CTS-1000 system).

Signed-off-by: Ben Collins <[email protected]>
Cc: [email protected]
---
include/linux/phy.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/include/linux/phy.h b/include/linux/phy.h
index 33999ad..5a94ec7 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -64,6 +64,7 @@ typedef enum {
PHY_INTERFACE_MODE_RGMII_TXID,
PHY_INTERFACE_MODE_RTBI,
PHY_INTERFACE_MODE_SMII,
+ PHY_INTERFACE_MODE_XGMII,
} phy_interface_t;


--
1.8.1.2


2013-03-22 14:13:01

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] phy: Add XGMII phy interface type

From: Ben Collins <[email protected]>
Date: Mon, 18 Mar 2013 19:53:42 -0400

> Used by systems based on certain Freescale SoCs (specifically the
> Servergy CTS-1000 system).
>
> Signed-off-by: Ben Collins <[email protected]>

You can resubmit this patch when you submit a driver upstream that
uses it, so we can see what the use case looks like.

2013-03-22 14:17:37

by Ben Collins

[permalink] [raw]
Subject: Re: [PATCH] phy: Add XGMII phy interface type

On Mar 22, 2013, at 10:12 AM, David Miller <[email protected]> wrote:

> From: Ben Collins <[email protected]>
> Date: Mon, 18 Mar 2013 19:53:42 -0400
>
>> Used by systems based on certain Freescale SoCs (specifically the
>> Servergy CTS-1000 system).
>>
>> Signed-off-by: Ben Collins <[email protected]>
>
> You can resubmit this patch when you submit a driver upstream that
> uses it, so we can see what the use case looks like.

That patch is getting sent soon. It's starting out in staging. Should I Cc you on that?

--
Servergy : http://www.servergy.com/
SwissDisk : http://www.swissdisk.com/
Ubuntu : http://www.ubuntu.com/
My Blog : http://ben-collins.blogspot.com/

2013-03-22 14:19:05

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] phy: Add XGMII phy interface type

From: Ben Collins <[email protected]>
Date: Fri, 22 Mar 2013 10:17:35 -0400

> On Mar 22, 2013, at 10:12 AM, David Miller <[email protected]> wrote:
>
>> From: Ben Collins <[email protected]>
>> Date: Mon, 18 Mar 2013 19:53:42 -0400
>>
>>> Used by systems based on certain Freescale SoCs (specifically the
>>> Servergy CTS-1000 system).
>>>
>>> Signed-off-by: Ben Collins <[email protected]>
>>
>> You can resubmit this patch when you submit a driver upstream that
>> uses it, so we can see what the use case looks like.
>
> That patch is getting sent soon. It's starting out in staging. Should I Cc you on that?

Why don't you wait until the driver is good enough for drivers/net proper?

2013-03-22 14:22:08

by Ben Collins

[permalink] [raw]
Subject: Re: [PATCH] phy: Add XGMII phy interface type

On Mar 22, 2013, at 10:19 AM, David Miller <[email protected]> wrote:

> From: Ben Collins <[email protected]>
> Date: Fri, 22 Mar 2013 10:17:35 -0400
>
>> On Mar 22, 2013, at 10:12 AM, David Miller <[email protected]> wrote:
>>
>>> From: Ben Collins <[email protected]>
>>> Date: Mon, 18 Mar 2013 19:53:42 -0400
>>>
>>>> Used by systems based on certain Freescale SoCs (specifically the
>>>> Servergy CTS-1000 system).
>>>>
>>>> Signed-off-by: Ben Collins <[email protected]>
>>>
>>> You can resubmit this patch when you submit a driver upstream that
>>> uses it, so we can see what the use case looks like.
>>
>> That patch is getting sent soon. It's starting out in staging. Should I Cc you on that?
>
> Why don't you wait until the driver is good enough for drivers/net proper?


It's code that I've manually stripped down as a subset of a larger code base for Freescale's DPAA driver. I've only tested it on our (Servergy's) platform, so until it gets more broad testing (and some code review), I want to at least get it into staging so our hardware is supported.

--
Servergy : http://www.servergy.com/
SwissDisk : http://www.swissdisk.com/
Ubuntu : http://www.ubuntu.com/
My Blog : http://ben-collins.blogspot.com/

2013-03-22 14:27:42

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] phy: Add XGMII phy interface type

From: Ben Collins <[email protected]>
Date: Fri, 22 Mar 2013 10:22:05 -0400

> It's code that I've manually stripped down as a subset of a larger
> code base for Freescale's DPAA driver. I've only tested it on our
> (Servergy's) platform, so until it gets more broad testing (and some
> code review), I want to at least get it into staging so our hardware
> is supported.

Then why don't you submit the PHY type addition with the staging
driver, which will be the only user, and you can add my:

Acked-by: David S. Miller <[email protected]>

to that.

Thanks.

2013-03-22 14:33:39

by Ben Collins

[permalink] [raw]
Subject: Re: [PATCH] phy: Add XGMII phy interface type

On Mar 22, 2013, at 10:27 AM, David Miller <[email protected]> wrote:

> From: Ben Collins <[email protected]>
> Date: Fri, 22 Mar 2013 10:22:05 -0400
>
>> It's code that I've manually stripped down as a subset of a larger
>> code base for Freescale's DPAA driver. I've only tested it on our
>> (Servergy's) platform, so until it gets more broad testing (and some
>> code review), I want to at least get it into staging so our hardware
>> is supported.
>
> Then why don't you submit the PHY type addition with the staging
> driver, which will be the only user, and you can add my:
>
> Acked-by: David S. Miller <[email protected]>


That I can do. Greg had asked I get all the rest of this signed off before he could take the driver into staging.

--
Servergy : http://www.servergy.com/
SwissDisk : http://www.swissdisk.com/
Ubuntu : http://www.ubuntu.com/
My Blog : http://ben-collins.blogspot.com/