2023-01-03 17:19:43

by Russell King (Oracle)

Subject: [PATCH] MAINTAINERS: stop nvme matching for nvmem files

The nvme patterns detect all include files starting with nvme, which
also picks up the nvmem subsystem header files. Fix this by excluding
the nvmem subsystem header files from the nvme subsystem entry.

Signed-off-by: Russell King (Oracle) <[email protected]>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 0cccd40d7801..64cc6947099e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14711,6 +14711,7 @@ T: git://git.infradead.org/nvme.git
F: drivers/nvme/host/
F: drivers/nvme/common/
F: include/linux/nvme*
+X: include/linux/nvmem*
F: include/uapi/linux/nvme_ioctl.h

NVM EXPRESS FABRICS AUTHENTICATION
--
2.30.2

2023-01-08 17:21:41

by Christoph Hellwig

Subject: Re: [PATCH] MAINTAINERS: stop nvme matching for nvmem files

> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0cccd40d7801..64cc6947099e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -14711,6 +14711,7 @@ T: git://git.infradead.org/nvme.git
> F: drivers/nvme/host/
> F: drivers/nvme/common/
> F: include/linux/nvme*
> +X: include/linux/nvmem*

I think the proper thing to do would to just match the right files
from the start:

F: include/linux/nvme.h
F: include/linux/nvme-*.h

is it ok if I commit it with your original attributation with that
change?

2023-01-09 18:10:40

by Russell King (Oracle)

Subject: Re: [PATCH] MAINTAINERS: stop nvme matching for nvmem files

On Sun, Jan 08, 2023 at 06:05:20PM +0100, Christoph Hellwig wrote:
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 0cccd40d7801..64cc6947099e 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -14711,6 +14711,7 @@ T: git://git.infradead.org/nvme.git
> > F: drivers/nvme/host/
> > F: drivers/nvme/common/
> > F: include/linux/nvme*
> > +X: include/linux/nvmem*
>
> I think the proper thing to do would to just match the right files
> from the start:
>
> F: include/linux/nvme.h
> F: include/linux/nvme-*.h
>
> is it ok if I commit it with your original attributation with that
> change?

LGTM, thanks!

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

2023-01-10 07:26:37

by Christoph Hellwig

Subject: Re: [PATCH] MAINTAINERS: stop nvme matching for nvmem files

On Mon, Jan 09, 2023 at 05:21:57PM +0000, Russell King (Oracle) wrote:
> > I think the proper thing to do would to just match the right files
> > from the start:
> >
> > F: include/linux/nvme.h
> > F: include/linux/nvme-*.h
> >
> > is it ok if I commit it with your original attributation with that
> > change?
>
> LGTM, thanks!

Thanks, I've added the updated version to the nvme-6.2 branch.