2019-02-11 20:34:17

by Andreas Kemnade

Subject: [PATCH] ARM: dts: omap3-gta04: declare backlight in lcd node

The lcd display of the gta04 has a backlight but the backlight
was not referenced in the lcd node, so screen blanking did
not turn off the backlight. Fix that.

Signed-off-by: Andreas Kemnade <[email protected]>
---
the backlight property for the driver was accepted here:
https://lore.kernel.org/lkml/[email protected]/

arch/arm/boot/dts/omap3-gta04.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index 8c55d33ff694..3b88eb5f1a72 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -142,6 +142,7 @@
spi-cpol;
spi-cpha;

+ backlight= <&backlight>;
label = "lcd";
port {
lcd_in: endpoint {
@@ -151,7 +152,7 @@
};
};

- backlight {
+ backlight: backlight {
compatible = "pwm-backlight";
pwms = <&pwm11 0 12000000 0>;
pwm-names = "backlight";
--
2.11.0

2019-02-11 20:36:42

by H. Nikolaus Schaller

Subject: Re: [Letux-kernel] [PATCH] ARM: dts: omap3-gta04: declare backlight in lcd node

> Am 11.02.2019 um 17:20 schrieb Andreas Kemnade <[email protected]>:
>
> The lcd display of the gta04 has a backlight but the backlight
> was not referenced in the lcd node, so screen blanking did
> not turn off the backlight. Fix that.
>
> Signed-off-by: Andreas Kemnade <[email protected]>

Works fine.

Tested-by: H. Nikolaus Schaller <[email protected]>

> ---
> the backlight property for the driver was accepted here:
> https://lore.kernel.org/lkml/[email protected]/
>
> arch/arm/boot/dts/omap3-gta04.dtsi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
> index 8c55d33ff694..3b88eb5f1a72 100644
> --- a/arch/arm/boot/dts/omap3-gta04.dtsi
> +++ b/arch/arm/boot/dts/omap3-gta04.dtsi
> @@ -142,6 +142,7 @@
> spi-cpol;
> spi-cpha;
>
> + backlight= <&backlight>;
> label = "lcd";
> port {
> lcd_in: endpoint {
> @@ -151,7 +152,7 @@
> };
> };
>
> - backlight {
> + backlight: backlight {
> compatible = "pwm-backlight";
> pwms = <&pwm11 0 12000000 0>;
> pwm-names = "backlight";
> --
> 2.11.0
>
> _______________________________________________
> http://projects.goldelico.com/p/gta04-kernel/
> Letux-kernel mailing list
> [email protected]
> http://lists.goldelico.com/mailman/listinfo.cgi/letux-kernel

2019-02-13 16:13:21

by Tony Lindgren

Subject: Re: [Letux-kernel] [PATCH] ARM: dts: omap3-gta04: declare backlight in lcd node

* H. Nikolaus Schaller <[email protected]> [190211 18:14]:
>
> > Am 11.02.2019 um 17:20 schrieb Andreas Kemnade <[email protected]>:
> >
> > The lcd display of the gta04 has a backlight but the backlight
> > was not referenced in the lcd node, so screen blanking did
> > not turn off the backlight. Fix that.
> >
> > Signed-off-by: Andreas Kemnade <[email protected]>
>
> Works fine.
>
> Tested-by: H. Nikolaus Schaller <[email protected]>

Thanks applied into omap-for-v5.1/dt.

Tony