2007-12-11 15:20:53

by Rini van Zetten

Subject: [PATCH]drivers/net/phy/: default return value in ioctl phy.c

Hello Andy,

This patch (to 2.6.23.9) add a default return value EOPNOTSUPP to the ioctl
function. The problem with the always 0 return value is that the iwconfig
(wireless) tool found a valid device when an ethernet device uses the phy
abstraction layer.
I 've tetsted this with the macb driver.


Signed-off-by: Rini van Zetten <[email protected]>

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index cb230f4..c07460d 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -405,6 +405,8 @@ int phy_mii_ioctl(struct phy_device *phydev,
&& phydev->drv->config_init)
phydev->drv->config_init(phydev);
break;
+ default:
+ return -EOPNOTSUPP;
}

return 0;

2008-01-14 18:48:48

by Andy Fleming

Subject: Re: [PATCH]drivers/net/phy/: default return value in ioctl phy.c

On Dec 11, 2007, at 09:02, Rini van Zetten wrote:

> Hello Andy,
>
> This patch (to 2.6.23.9) add a default return value EOPNOTSUPP to
> the ioctl function. The problem with the always 0 return value is
> that the iwconfig (wireless) tool found a valid device when an
> ethernet device uses the phy abstraction layer.
> I 've tetsted this with the macb driver.
>
>
> Signed-off-by: Rini van Zetten <[email protected]>

Acked-by: Andy Fleming <[email protected]>