2022-02-09 18:15:09

by Haakon Bugge

Subject: [PATCH for-rc v2] IB/cma: Allow XRG INI QPs to set their local ACK timeout

XRC INI QPs should be able to adjust their local ACK timeout.

Fixes: 2c1619edef61 ("IB/cma: Define option to set ack timeout and pack tos_set")
Signed-off-by: Håkon Bugge <[email protected]>
Suggested-by: Avneesh Pant <[email protected]>

---

v1 -> v2:
* Removed WARN_ON as suggested by Leon
---
drivers/infiniband/core/cma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index 0f5f0d7..7adacd1 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -2811,7 +2811,7 @@ int rdma_set_ack_timeout(struct rdma_cm_id *id, u8 timeout)
{
struct rdma_id_private *id_priv;

- if (id->qp_type != IB_QPT_RC)
+ if (id->qp_type != IB_QPT_RC && id->qp_type != IB_QPT_XRC_INI)
return -EINVAL;

id_priv = container_of(id, struct rdma_id_private, id);
--
1.8.3.1

2022-02-14 10:19:58

by Leon Romanovsky

Subject: Re: [PATCH for-rc v2] IB/cma: Allow XRG INI QPs to set their local ACK timeout

On Wed, Feb 09, 2022 at 04:39:35PM +0100, H?kon Bugge wrote:
> XRC INI QPs should be able to adjust their local ACK timeout.
>
> Fixes: 2c1619edef61 ("IB/cma: Define option to set ack timeout and pack tos_set")
> Signed-off-by: H?kon Bugge <[email protected]>
> Suggested-by: Avneesh Pant <[email protected]>
>
> ---
>

Thanks,
Reviewed-by: Leon Romanovsky <[email protected]>

2022-02-17 15:39:19

by Jason Gunthorpe

Subject: Re: [PATCH for-rc v2] IB/cma: Allow XRG INI QPs to set their local ACK timeout

On Thu, Feb 17, 2022 at 11:29:41AM +0000, Haakon Bugge wrote:
>
>
> > On 13 Feb 2022, at 12:56, Leon Romanovsky <[email protected]> wrote:
> >
> > On Wed, Feb 09, 2022 at 04:39:35PM +0100, Håkon Bugge wrote:
> >> XRC INI QPs should be able to adjust their local ACK timeout.
> >>
> >> Fixes: 2c1619edef61 ("IB/cma: Define option to set ack timeout and pack tos_set")
> >> Signed-off-by: Håkon Bugge <[email protected]>
> >> Suggested-by: Avneesh Pant <[email protected]>
> >>
> >>
> >
> > Thanks,
> > Reviewed-by: Leon Romanovsky <[email protected]>
>
> Thanks Leon. I just saw that we need a s/XRG/XRC/ in $Subject. Shall I send a v3?

I will fix it

Jason

2022-02-17 16:44:55

by Jason Gunthorpe

Subject: Re: [PATCH for-rc v2] IB/cma: Allow XRG INI QPs to set their local ACK timeout

On Wed, Feb 09, 2022 at 04:39:35PM +0100, Håkon Bugge wrote:
> XRC INI QPs should be able to adjust their local ACK timeout.
>
> Fixes: 2c1619edef61 ("IB/cma: Define option to set ack timeout and pack tos_set")
> Signed-off-by: Håkon Bugge <[email protected]>
> Suggested-by: Avneesh Pant <[email protected]>
> Reviewed-by: Leon Romanovsky <[email protected]>
> ---
>
> v1 -> v2:
> * Removed WARN_ON as suggested by Leon
> ---
> drivers/infiniband/core/cma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-next, thanks

Jason

2022-02-17 17:52:53

by Haakon Bugge

Subject: Re: [PATCH for-rc v2] IB/cma: Allow XRG INI QPs to set their local ACK timeout

> On 13 Feb 2022, at 12:56, Leon Romanovsky <[email protected]> wrote:
>
> On Wed, Feb 09, 2022 at 04:39:35PM +0100, Håkon Bugge wrote:
>> XRC INI QPs should be able to adjust their local ACK timeout.
>>
>> Fixes: 2c1619edef61 ("IB/cma: Define option to set ack timeout and pack tos_set")
>> Signed-off-by: Håkon Bugge <[email protected]>
>> Suggested-by: Avneesh Pant <[email protected]>
>>
>> ---
>>
>
> Thanks,
> Reviewed-by: Leon Romanovsky <[email protected]>

Thanks Leon. I just saw that we need a s/XRG/XRC/ in $Subject. Shall I send a v3?


Thxs, Håkon