Currently both da903x backlight and voltage reulator drivers have the
same name. Rename the backlight driver to allow use of both drivers as
modules.
Signed-off-by: Mike Rapoport <[email protected]>
---
drivers/video/backlight/Makefile | 2 +-
drivers/video/backlight/{da903x.c => da903x_bl.c} | 0
2 files changed, 1 insertions(+), 1 deletions(-)
rename drivers/video/backlight/{da903x.c => da903x_bl.c} (100%)
diff --git a/drivers/video/backlight/Makefile b/drivers/video/backlight/Makefile
index 103427d..2d8f7cb 100644
--- a/drivers/video/backlight/Makefile
+++ b/drivers/video/backlight/Makefile
@@ -18,7 +18,7 @@ obj-$(CONFIG_BACKLIGHT_OMAP1) += omap1_bl.o
obj-$(CONFIG_BACKLIGHT_PROGEAR) += progear_bl.o
obj-$(CONFIG_BACKLIGHT_CARILLO_RANCH) += cr_bllcd.o
obj-$(CONFIG_BACKLIGHT_PWM) += pwm_bl.o
-obj-$(CONFIG_BACKLIGHT_DA903X) += da903x.o
+obj-$(CONFIG_BACKLIGHT_DA903X) += da903x_bl.o
obj-$(CONFIG_BACKLIGHT_MBP_NVIDIA) += mbp_nvidia_bl.o
obj-$(CONFIG_BACKLIGHT_TOSA) += tosa_bl.o
obj-$(CONFIG_BACKLIGHT_SAHARA) += kb3886_bl.o
diff --git a/drivers/video/backlight/da903x.c b/drivers/video/backlight/da903x_bl.c
similarity index 100%
rename from drivers/video/backlight/da903x.c
rename to drivers/video/backlight/da903x_bl.c
--
1.5.6.4
Isn't modprobe supposed to be smart enough for things like this?
I'm afraid if modprobe isn't so capable, we may encounter the same
issue with other drivers and sometimes it is not so easy for
developers of aphasia like me to choose a better name :)
- eric
-----Original Message-----
From: Mike Rapoport [mailto:[email protected]]
Sent: Tuesday, November 25, 2008 5:43 PM
To: [email protected]
Cc: Eric Miao; [email protected]; Mike Rapoport
Subject: [PATCH] drivers/video/backlight: rename da903x to da903x_bl
Currently both da903x backlight and voltage reulator drivers have the
same name. Rename the backlight driver to allow use of both drivers as
modules.
Signed-off-by: Mike Rapoport <[email protected]>
---
drivers/video/backlight/Makefile | 2 +-
drivers/video/backlight/{da903x.c => da903x_bl.c} | 0
2 files changed, 1 insertions(+), 1 deletions(-)
rename drivers/video/backlight/{da903x.c => da903x_bl.c} (100%)
diff --git a/drivers/video/backlight/Makefile
b/drivers/video/backlight/Makefile
index 103427d..2d8f7cb 100644
--- a/drivers/video/backlight/Makefile
+++ b/drivers/video/backlight/Makefile
@@ -18,7 +18,7 @@ obj-$(CONFIG_BACKLIGHT_OMAP1) += omap1_bl.o
obj-$(CONFIG_BACKLIGHT_PROGEAR) += progear_bl.o
obj-$(CONFIG_BACKLIGHT_CARILLO_RANCH) += cr_bllcd.o
obj-$(CONFIG_BACKLIGHT_PWM) += pwm_bl.o
-obj-$(CONFIG_BACKLIGHT_DA903X) += da903x.o
+obj-$(CONFIG_BACKLIGHT_DA903X) += da903x_bl.o
obj-$(CONFIG_BACKLIGHT_MBP_NVIDIA) += mbp_nvidia_bl.o
obj-$(CONFIG_BACKLIGHT_TOSA) += tosa_bl.o
obj-$(CONFIG_BACKLIGHT_SAHARA) += kb3886_bl.o
diff --git a/drivers/video/backlight/da903x.c
b/drivers/video/backlight/da903x_bl.c
similarity index 100%
rename from drivers/video/backlight/da903x.c
rename to drivers/video/backlight/da903x_bl.c
--
1.5.6.4
Eric Miao wrote:
> Isn't modprobe supposed to be smart enough for things like this?
Here's snap from build log:
mike@gentoodev /mnt/sdb1/git/linux-2.6-arm $ touch drivers/video/backlight/da903x.c
mike@gentoodev /mnt/sdb1/git/linux-2.6-arm $ touch drivers/regulator/da903x.c
mike@gentoodev /mnt/sdb1/git/linux-2.6-arm $ make O=/home/mike/arm/kernel/build/pxa/ modules
CHK include/linux/version.h
make[2]: `include/asm-arm/mach-types.h' is up to date.
Using /mnt/sdb1/git/linux-2.6-arm as source for kernel
GEN /home/mike/arm/kernel/build/pxa/Makefile
CHK include/linux/utsrelease.h
SYMLINK include/asm -> include/asm-arm
CALL /mnt/sdb1/git/linux-2.6-arm/scripts/checksyscalls.sh
<stdin>:1097:2: warning: #warning syscall fadvise64 not implemented
<stdin>:1265:2: warning: #warning syscall migrate_pages not implemented
<stdin>:1321:2: warning: #warning syscall pselect6 not implemented
<stdin>:1325:2: warning: #warning syscall ppoll not implemented
<stdin>:1365:2: warning: #warning syscall epoll_pwait not implemented
CC [M] drivers/regulator/da903x.o
CC [M] drivers/video/backlight/da903x.o
Building modules, stage 2.
MODPOST 70 modules
LD [M] drivers/video/backlight/da903x.ko
mike@gentoodev /mnt/sdb1/git/linux-2.6-arm $
So, apparently modpost is not smart enough for things like this :)
> I'm afraid if modprobe isn't so capable, we may encounter the same
> issue with other drivers and sometimes it is not so easy for
> developers of aphasia like me to choose a better name :)
>
> - eric
>
> -----Original Message-----
> From: Mike Rapoport [mailto:[email protected]]
> Sent: Tuesday, November 25, 2008 5:43 PM
> To: [email protected]
> Cc: Eric Miao; [email protected]; Mike Rapoport
> Subject: [PATCH] drivers/video/backlight: rename da903x to da903x_bl
>
> Currently both da903x backlight and voltage reulator drivers have the
> same name. Rename the backlight driver to allow use of both drivers as
> modules.
>
> Signed-off-by: Mike Rapoport <[email protected]>
> ---
> drivers/video/backlight/Makefile | 2 +-
> drivers/video/backlight/{da903x.c => da903x_bl.c} | 0
> 2 files changed, 1 insertions(+), 1 deletions(-)
> rename drivers/video/backlight/{da903x.c => da903x_bl.c} (100%)
>
> diff --git a/drivers/video/backlight/Makefile
> b/drivers/video/backlight/Makefile
> index 103427d..2d8f7cb 100644
> --- a/drivers/video/backlight/Makefile
> +++ b/drivers/video/backlight/Makefile
> @@ -18,7 +18,7 @@ obj-$(CONFIG_BACKLIGHT_OMAP1) += omap1_bl.o
> obj-$(CONFIG_BACKLIGHT_PROGEAR) += progear_bl.o
> obj-$(CONFIG_BACKLIGHT_CARILLO_RANCH) += cr_bllcd.o
> obj-$(CONFIG_BACKLIGHT_PWM) += pwm_bl.o
> -obj-$(CONFIG_BACKLIGHT_DA903X) += da903x.o
> +obj-$(CONFIG_BACKLIGHT_DA903X) += da903x_bl.o
> obj-$(CONFIG_BACKLIGHT_MBP_NVIDIA) += mbp_nvidia_bl.o
> obj-$(CONFIG_BACKLIGHT_TOSA) += tosa_bl.o
> obj-$(CONFIG_BACKLIGHT_SAHARA) += kb3886_bl.o
> diff --git a/drivers/video/backlight/da903x.c
> b/drivers/video/backlight/da903x_bl.c
> similarity index 100%
> rename from drivers/video/backlight/da903x.c
> rename to drivers/video/backlight/da903x_bl.c
--
Sincerely yours,
Mike.
Sam,
Do you have any suggestion to this?
On Tue, Nov 25, 2008 at 6:01 PM, Mike Rapoport <[email protected]> wrote:
>
>
> Eric Miao wrote:
>> Isn't modprobe supposed to be smart enough for things like this?
>
> Here's snap from build log:
>
> mike@gentoodev /mnt/sdb1/git/linux-2.6-arm $ touch drivers/video/backlight/da903x.c
> mike@gentoodev /mnt/sdb1/git/linux-2.6-arm $ touch drivers/regulator/da903x.c
> mike@gentoodev /mnt/sdb1/git/linux-2.6-arm $ make O=/home/mike/arm/kernel/build/pxa/ modules
> CHK include/linux/version.h
> make[2]: `include/asm-arm/mach-types.h' is up to date.
> Using /mnt/sdb1/git/linux-2.6-arm as source for kernel
> GEN /home/mike/arm/kernel/build/pxa/Makefile
> CHK include/linux/utsrelease.h
> SYMLINK include/asm -> include/asm-arm
> CALL /mnt/sdb1/git/linux-2.6-arm/scripts/checksyscalls.sh
> <stdin>:1097:2: warning: #warning syscall fadvise64 not implemented
> <stdin>:1265:2: warning: #warning syscall migrate_pages not implemented
> <stdin>:1321:2: warning: #warning syscall pselect6 not implemented
> <stdin>:1325:2: warning: #warning syscall ppoll not implemented
> <stdin>:1365:2: warning: #warning syscall epoll_pwait not implemented
> CC [M] drivers/regulator/da903x.o
> CC [M] drivers/video/backlight/da903x.o
> Building modules, stage 2.
> MODPOST 70 modules
> LD [M] drivers/video/backlight/da903x.ko
> mike@gentoodev /mnt/sdb1/git/linux-2.6-arm $
>
> So, apparently modpost is not smart enough for things like this :)
>
>> I'm afraid if modprobe isn't so capable, we may encounter the same
>> issue with other drivers and sometimes it is not so easy for
>> developers of aphasia like me to choose a better name :)
>>
>> - eric
>>
>> -----Original Message-----
>> From: Mike Rapoport [mailto:[email protected]]
>> Sent: Tuesday, November 25, 2008 5:43 PM
>> To: [email protected]
>> Cc: Eric Miao; [email protected]; Mike Rapoport
>> Subject: [PATCH] drivers/video/backlight: rename da903x to da903x_bl
>>
>> Currently both da903x backlight and voltage reulator drivers have the
>> same name. Rename the backlight driver to allow use of both drivers as
>> modules.
>>
>> Signed-off-by: Mike Rapoport <[email protected]>
>> ---
>> drivers/video/backlight/Makefile | 2 +-
>> drivers/video/backlight/{da903x.c => da903x_bl.c} | 0
>> 2 files changed, 1 insertions(+), 1 deletions(-)
>> rename drivers/video/backlight/{da903x.c => da903x_bl.c} (100%)
>>
>> diff --git a/drivers/video/backlight/Makefile
>> b/drivers/video/backlight/Makefile
>> index 103427d..2d8f7cb 100644
>> --- a/drivers/video/backlight/Makefile
>> +++ b/drivers/video/backlight/Makefile
>> @@ -18,7 +18,7 @@ obj-$(CONFIG_BACKLIGHT_OMAP1) += omap1_bl.o
>> obj-$(CONFIG_BACKLIGHT_PROGEAR) += progear_bl.o
>> obj-$(CONFIG_BACKLIGHT_CARILLO_RANCH) += cr_bllcd.o
>> obj-$(CONFIG_BACKLIGHT_PWM) += pwm_bl.o
>> -obj-$(CONFIG_BACKLIGHT_DA903X) += da903x.o
>> +obj-$(CONFIG_BACKLIGHT_DA903X) += da903x_bl.o
>> obj-$(CONFIG_BACKLIGHT_MBP_NVIDIA) += mbp_nvidia_bl.o
>> obj-$(CONFIG_BACKLIGHT_TOSA) += tosa_bl.o
>> obj-$(CONFIG_BACKLIGHT_SAHARA) += kb3886_bl.o
>> diff --git a/drivers/video/backlight/da903x.c
>> b/drivers/video/backlight/da903x_bl.c
>> similarity index 100%
>> rename from drivers/video/backlight/da903x.c
>> rename to drivers/video/backlight/da903x_bl.c
>
> --
> Sincerely yours,
> Mike.
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Cheers
- eric
On Wed, Nov 26, 2008 at 04:12:07PM +0800, Eric Miao wrote:
> Sam,
>
> Do you have any suggestion to this?
>
[snip two modules with same name does not work...]
kbuild today create one file for each module in the
directory: .tmp_versions/
So in this case the module that is build lst is the winner.
I do not see any easy way to avoid this.
What we could do:
1) find another way to record what modules we have
2) embed path in filename
I did not try to actually implement any of the above
as the gain seems minimal compared to the additional complexity.
Sam
On Sat, Nov 29, 2008 at 9:03 PM, Sam Ravnborg <[email protected]> wrote:
> On Wed, Nov 26, 2008 at 04:12:07PM +0800, Eric Miao wrote:
>> Sam,
>>
>> Do you have any suggestion to this?
>>
> [snip two modules with same name does not work...]
>
> kbuild today create one file for each module in the
> directory: .tmp_versions/
>
> So in this case the module that is build lst is the winner.
>
> I do not see any easy way to avoid this.
> What we could do:
> 1) find another way to record what modules we have
> 2) embed path in filename
>
> I did not try to actually implement any of the above
> as the gain seems minimal compared to the additional complexity.
>
> Sam
>
OK, fair enough to add my Ack here to Mike's original patch:
Acked-by: Eric Miao <[email protected]>