2018-09-11 09:49:10

by Masanari Iida

Subject: [PATCH] scsi: qla2xxx: Fix comment in MODULE_PARM_DESC in qla2xxx

Default value of ql2xasynctmfenable for qla2xxx driver was
set to 1 in commit 043dc1d7e8501.
But comment in MODULE_PARAM_DESC was not modified.

Signed-off-by: Masanari Iida <[email protected]>
---
drivers/scsi/qla2xxx/qla_os.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 42b8f0d3e580..fe5404be73c5 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -204,7 +204,7 @@ int ql2xasynctmfenable = 1;
module_param(ql2xasynctmfenable, int, S_IRUGO);
MODULE_PARM_DESC(ql2xasynctmfenable,
"Enables issue of TM IOCBs asynchronously via IOCB mechanism"
- "Default is 0 - Issue TM IOCBs via mailbox mechanism.");
+ "Default is 1 - Issue TM IOCBs via mailbox mechanism.");

int ql2xdontresethba;
module_param(ql2xdontresethba, int, S_IRUGO|S_IWUSR);
--
2.19.0

2018-09-26 04:23:33

by Madhani, Himanshu

Subject: Re: [PATCH] scsi: qla2xxx: Fix comment in MODULE_PARM_DESC in qla2xxx

> On Sep 11, 2018, at 2:48 AM, Masanari Iida <[email protected]> wrote:
>
> External Email
>
> Default value of ql2xasynctmfenable for qla2xxx driver was
> set to 1 in commit 043dc1d7e8501.
> But comment in MODULE_PARAM_DESC was not modified.
>
> Signed-off-by: Masanari Iida <[email protected]>
> ---
> drivers/scsi/qla2xxx/qla_os.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index 42b8f0d3e580..fe5404be73c5 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -204,7 +204,7 @@ int ql2xasynctmfenable = 1;
> module_param(ql2xasynctmfenable, int, S_IRUGO);
> MODULE_PARM_DESC(ql2xasynctmfenable,
> "Enables issue of TM IOCBs asynchronously via IOCB mechanism"
> - "Default is 0 - Issue TM IOCBs via mailbox mechanism.");
> + "Default is 1 - Issue TM IOCBs via mailbox mechanism.");
>
> int ql2xdontresethba;
> module_param(ql2xdontresethba, int, S_IRUGO|S_IWUSR);
> --
> 2.19.0
>

Thanks for the patch.

Acked-by: Himanshu Madhani <[email protected]>

-Himanshu

2018-09-27 23:50:50

by Martin K. Petersen

Subject: Re: [PATCH] scsi: qla2xxx: Fix comment in MODULE_PARM_DESC in qla2xxx

Masanari,

> Default value of ql2xasynctmfenable for qla2xxx driver was set to 1 in
> commit 043dc1d7e8501. But comment in MODULE_PARAM_DESC was not
> modified.

Applied to 4.20/scsi-queue. Thank you!

--
Martin K. Petersen Oracle Linux Engineering