2004-11-09 06:18:19

by Kumar Gala

[permalink] [raw]
Subject: [PATCH][PPC32] Added MPC8555/8541 security block infrastructure

Andrew,

This patch adds OCP, interrupt, and memory offset details for the security
block on MPC8555/8541 to support drivers.

Signed-off-by: Kumar Gala <[email protected]>

--

diff -Nru a/arch/ppc/platforms/85xx/mpc8555.c b/arch/ppc/platforms/85xx/mpc8555.c
--- a/arch/ppc/platforms/85xx/mpc8555.c 2004-11-08 21:33:21 -06:00
+++ b/arch/ppc/platforms/85xx/mpc8555.c 2004-11-08 21:33:21 -06:00
@@ -77,6 +77,13 @@
.pm = OCP_CPM_NA,
},
{ .vendor = OCP_VENDOR_FREESCALE,
+ .function = OCP_FUNC_SEC2,
+ .index = 0,
+ .paddr = MPC85xx_SEC2_OFFSET,
+ .irq = MPC85xx_IRQ_SEC2,
+ .pm = OCP_CPM_NA,
+ },
+ { .vendor = OCP_VENDOR_FREESCALE,
.function = OCP_FUNC_PERFMON,
.index = 0,
.paddr = MPC85xx_PERFMON_OFFSET,
diff -Nru a/include/asm-ppc/mpc85xx.h b/include/asm-ppc/mpc85xx.h
--- a/include/asm-ppc/mpc85xx.h 2004-11-08 21:33:21 -06:00
+++ b/include/asm-ppc/mpc85xx.h 2004-11-08 21:33:21 -06:00
@@ -81,6 +81,7 @@
#define MPC85xx_IRQ_DUART (26 + MPC85xx_OPENPIC_IRQ_OFFSET)
#define MPC85xx_IRQ_IIC1 (27 + MPC85xx_OPENPIC_IRQ_OFFSET)
#define MPC85xx_IRQ_PERFMON (28 + MPC85xx_OPENPIC_IRQ_OFFSET)
+#define MPC85xx_IRQ_SEC2 (29 + MPC85xx_OPENPIC_IRQ_OFFSET)
#define MPC85xx_IRQ_CPM (30 + MPC85xx_OPENPIC_IRQ_OFFSET)

/* The 12 external interrupt lines */
@@ -120,6 +121,8 @@
#define MPC85xx_PCI2_SIZE (0x01000)
#define MPC85xx_PERFMON_OFFSET (0xe1000)
#define MPC85xx_PERFMON_SIZE (0x01000)
+#define MPC85xx_SEC2_OFFSET (0x30000)
+#define MPC85xx_SEC2_SIZE (0x10000)
#define MPC85xx_UART0_OFFSET (0x04500)
#define MPC85xx_UART0_SIZE (0x00100)
#define MPC85xx_UART1_OFFSET (0x04600)
diff -Nru a/include/asm-ppc/ocp_ids.h b/include/asm-ppc/ocp_ids.h
--- a/include/asm-ppc/ocp_ids.h 2004-11-08 21:33:21 -06:00
+++ b/include/asm-ppc/ocp_ids.h 2004-11-08 21:33:21 -06:00
@@ -61,6 +61,7 @@
#define OCP_FUNC_PERFMON 0x00D2 /* Performance Monitor */
#define OCP_FUNC_RGMII 0x00D3
#define OCP_FUNC_TAH 0x00D4
+#define OCP_FUNC_SEC2 0x00D5 /* Crypto/Security 2.0 */

/* Network 0x0200 - 0x02FF */
#define OCP_FUNC_EMAC 0x0200


2004-11-09 05:59:00

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH][PPC32] Added MPC8555/8541 security block infrastructure

Kumar Gala <[email protected]> wrote:
>
> This patch adds OCP, interrupt, and memory offset details for the security
> block on MPC8555/8541 to support drivers.

Your email client did space-stuffing on the message, so the patch gets 100%
rejects. I fixed it up by hand and applied the patch locally, thanks.

I think there's a way of telling Pine to stop doing this.

2004-11-09 06:03:02

by Kumar Gala

[permalink] [raw]
Subject: Re: [PATCH][PPC32] Added MPC8555/8541 security block infrastructure

Uugh, sorry. The previous version of pine I was using did not do this.
I will look at trying to change its settings. Thanks for reformatting
the patch. Can you explain further what you mean by 'space-stuffing'

thanks

- kumar

On Nov 8, 2004, at 11:34 PM, Andrew Morton wrote:

> Kumar Gala <[email protected]> wrote:
> >
> > This patch adds OCP, interrupt, and memory offset details for the
> security
> >? block on MPC8555/8541 to support drivers.
>
> Your email client did space-stuffing on the message, so the patch gets
> 100%
> rejects.? I fixed it up by hand and applied the patch locally, thanks.
>
> I think there's a way of telling Pine to stop doing this.

2004-11-09 06:22:27

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH][PPC32] Added MPC8555/8541 security block infrastructure

Kumar Gala <[email protected]> wrote:
>
> Can you explain further what you mean by 'space-stuffing'

Some madness cooked up by people who think they know better than you. See
RFC2646.

2004-11-09 09:12:54

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH][PPC32] Added MPC8555/8541 security block infrastructure

On Mon, 8 Nov 2004, Kumar Gala wrote:
> Uugh, sorry. The previous version of pine I was using did not do this. I
> will look at trying to change its settings. Thanks for reformatting the
> patch. Can you explain further what you mean by 'space-stuffing'

IIRC, you have to enable quell-flowed-text.

Always read the release notes after upgrading pine ;-)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds