2018-06-22 12:28:23

by Icenowy Zheng

[permalink] [raw]
Subject: [PATCH v2 0/7] Allwinner A64 DE2 CCU support with dedicated DE2 bus driver

This patchset tries to implement the Allwinner A64 DE2 as a bus driver,
in order to model the fact that the SRAM claim controls the access to
the whole DE2 memory space.

PATCH 1 and PATCH 4 are for the CCU part.

PATCH 2 is the device tree binding for the A64 DE2 bus, and PATCH 3
implements the bus driver.

PATCH 5 adds the DE2 CCU device tree node, with the DE2 bus node.

PATCH 6 and 7 are HDMI simplefb patches for A64. They're present as a
test to this patchset.

Icenowy Zheng (7):
dt-bindings: add compatible string for the A64 DE2 CCU
dt-bindings: add binding for the Allwinner A64 DE2 bus
bus: add bus driver for accessing Allwinner A64 DE2
clk: sunxi-ng: add A64 compatible string
arm64: allwinner: a64: add necessary device tree nodes for DE2 CCU
arm64: allwinner: a64: add device tree node for HDMI simplefb
arm64: allwinner: a64: add HDMI regulator to all DTs' simplefb_hdmi

.../bindings/bus/sun50i-de2-bus.txt | 37 ++++++++++++++
.../devicetree/bindings/clock/sun8i-de2.txt | 1 +
.../dts/allwinner/sun50i-a64-bananapi-m64.dts | 4 ++
.../dts/allwinner/sun50i-a64-nanopi-a64.dts | 4 ++
.../dts/allwinner/sun50i-a64-olinuxino.dts | 4 ++
.../dts/allwinner/sun50i-a64-orangepi-win.dts | 4 ++
.../boot/dts/allwinner/sun50i-a64-pine64.dts | 4 ++
.../dts/allwinner/sun50i-a64-pinebook.dts | 4 ++
.../allwinner/sun50i-a64-sopine-baseboard.dts | 4 ++
.../boot/dts/allwinner/sun50i-a64-teres-i.dts | 4 ++
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 39 ++++++++++++---
drivers/bus/Kconfig | 10 ++++
drivers/bus/Makefile | 1 +
drivers/bus/sun50i-de2.c | 49 +++++++++++++++++++
drivers/clk/sunxi-ng/ccu-sun8i-de2.c | 11 ++---
15 files changed, 167 insertions(+), 13 deletions(-)
create mode 100644 Documentation/devicetree/bindings/bus/sun50i-de2-bus.txt
create mode 100644 drivers/bus/sun50i-de2.c

--
2.17.1



2018-06-22 12:29:39

by Icenowy Zheng

[permalink] [raw]
Subject: [PATCH v2 1/7] dt-bindings: add compatible string for the A64 DE2 CCU

The Allwinner A64 SoC has a DE2 CCU like the one in the DE2 of Allwinner
H5 SoC.

Add a compatible string for it.

Signed-off-by: Icenowy Zheng <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
Acked-by: Stephen Boyd <[email protected]>
---
No changes since v1.

Documentation/devicetree/bindings/clock/sun8i-de2.txt | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/clock/sun8i-de2.txt b/Documentation/devicetree/bindings/clock/sun8i-de2.txt
index f2fa87c4765c..e94582e8b8a9 100644
--- a/Documentation/devicetree/bindings/clock/sun8i-de2.txt
+++ b/Documentation/devicetree/bindings/clock/sun8i-de2.txt
@@ -6,6 +6,7 @@ Required properties :
- "allwinner,sun8i-a83t-de2-clk"
- "allwinner,sun8i-h3-de2-clk"
- "allwinner,sun8i-v3s-de2-clk"
+ - "allwinner,sun50i-a64-de2-clk"
- "allwinner,sun50i-h5-de2-clk"

- reg: Must contain the registers base address and length
--
2.17.1


2018-06-25 16:03:47

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH v2 0/7] Allwinner A64 DE2 CCU support with dedicated DE2 bus driver

Hi,

On Fri, Jun 22, 2018 at 08:26:08PM +0800, Icenowy Zheng wrote:
> This patchset tries to implement the Allwinner A64 DE2 as a bus driver,
> in order to model the fact that the SRAM claim controls the access to
> the whole DE2 memory space.
>
> PATCH 1 and PATCH 4 are for the CCU part.
>
> PATCH 2 is the device tree binding for the A64 DE2 bus, and PATCH 3
> implements the bus driver.
>
> PATCH 5 adds the DE2 CCU device tree node, with the DE2 bus node.
>
> PATCH 6 and 7 are HDMI simplefb patches for A64. They're present as a
> test to this patchset.

Apart from the (minor) comments I made that can be fixed up while
applying, I'm happy with those changes. I'd still like to get a review
from Rob, so I'll wait for it to apply them.

Thanks a lot for working on this,
Maxime

--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com


Attachments:
(No filename) (929.00 B)
signature.asc (849.00 B)
Download all attachments

2018-06-27 18:38:19

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH v2 0/7] Allwinner A64 DE2 CCU support with dedicated DE2 bus driver

On Fri, Jun 22, 2018 at 08:26:08PM +0800, Icenowy Zheng wrote:
> This patchset tries to implement the Allwinner A64 DE2 as a bus driver,
> in order to model the fact that the SRAM claim controls the access to
> the whole DE2 memory space.
>
> PATCH 1 and PATCH 4 are for the CCU part.
>
> PATCH 2 is the device tree binding for the A64 DE2 bus, and PATCH 3
> implements the bus driver.
>
> PATCH 5 adds the DE2 CCU device tree node, with the DE2 bus node.
>
> PATCH 6 and 7 are HDMI simplefb patches for A64. They're present as a
> test to this patchset.

Applied all the patches with the minor modifications Chen-Yu and I
suggested.

The threading was broken on your serie though, so you probably want to
check your git configuration.

Thanks!
Maxime

--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com


Attachments:
(No filename) (896.00 B)
signature.asc (849.00 B)
Download all attachments

2018-06-27 20:50:24

by Icenowy Zheng

[permalink] [raw]
Subject: Re: [PATCH v2 0/7] Allwinner A64 DE2 CCU support with dedicated DE2 bus driver



于 2018年6月28日 GMT+08:00 上午2:37:21, Maxime Ripard <[email protected]> 写到:
>On Fri, Jun 22, 2018 at 08:26:08PM +0800, Icenowy Zheng wrote:
>> This patchset tries to implement the Allwinner A64 DE2 as a bus
>driver,
>> in order to model the fact that the SRAM claim controls the access to
>> the whole DE2 memory space.
>>
>> PATCH 1 and PATCH 4 are for the CCU part.
>>
>> PATCH 2 is the device tree binding for the A64 DE2 bus, and PATCH 3
>> implements the bus driver.
>>
>> PATCH 5 adds the DE2 CCU device tree node, with the DE2 bus node.
>>
>> PATCH 6 and 7 are HDMI simplefb patches for A64. They're present as a
>> test to this patchset.
>
>Applied all the patches with the minor modifications Chen-Yu and I
>suggested.
>
>The threading was broken on your serie though, so you probably want to
>check your git configuration.

In fact I think I should check my ISP configuration.

The breakage is introduced due to too long delay between aosc.io
mail server and my computer, so I must start to send the
remaining patches again.

>
>Thanks!
>Maxime